Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3.5] backport deflake TestV3AuthWithLeaseRevokeWithRootJWT #18253

Merged
merged 1 commit into from
Jun 30, 2024
Merged

[3.5] backport deflake TestV3AuthWithLeaseRevokeWithRootJWT #18253

merged 1 commit into from
Jun 30, 2024

Conversation

YaoC
Copy link
Contributor

@YaoC YaoC commented Jun 29, 2024

@YaoC
tests/integration: deflake TestV3AuthWithLeaseRevokeWithRootJWT
2dc3a3c 
Signed-off-by: Yao Cheng <chengyao09@hotmail.com>
@k8s-ci-robot
Copy link

Hi @YaoC. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@jmhbnz
Copy link
Member

jmhbnz commented Jun 29, 2024

/ok-to-test

jmhbnz
jmhbnz approved these changes Jun 29, 2024
View reviewed changes
Copy link
Member

@jmhbnz jmhbnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (and 2s is still the value being used in main currently).

Thanks for raising this @YaoC 🙏🏻

@ahrtr ahrtr merged commit 7b98547 into etcd-io:release-3.5 Jun 30, 2024
27 checks passed
@ivanvc ivanvc mentioned this pull request Jul 3, 2024
Closed
4 tasks
aneesh1 pushed a commit to DataDog/etcd that referenced this pull request Sep 24, 2024
@ahrtr @aneesh1
Merge pull request etcd-io#18253 from YaoC/backport-16523-to-release-3.5
11d8b39 
[3.5] backport deflake TestV3AuthWithLeaseRevokeWithRootJWT
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmhbnz jmhbnz jmhbnz approved these changes

@ahrtr ahrtr ahrtr approved these changes

Assignees
No one assigned
Labels
ok-to-test size/XS
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@YaoC @k8s-ci-robot @jmhbnz @ahrtr