-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[3.5] Support multiple values for allowed client and peer TLS identities #18160
Conversation
Hi @lhy1024. Thanks for your PR. I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your PR, @lhy1024. Please take a look at my comments. I suggest adding the original commit and PR to your commit message so it's easier to trace where this backport comes from later.
/ok-to-test |
…cd-io#18015) Signed-off-by: lhy1024 <admin@liudos.us>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From a backporting point of view, this looks correct. Thanks, @lhy1024.
cc. @ahrtr, @serathius.
PTAL @serathius @jmhbnz |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - Thanks for your efforts on this @lhy1024
I initially held off adding a review to this pull request as it's a feature, which ordinarily we would try to avoid backporting. However, given:
- Our next minor release is still distant
- Feature is minor in terms of impact to codebase
- Tests have been written and included in backport
- Community has asked for this and provided clear use case
I think it is best if we proceed with the backport and include it in etcd v3.5.15
Thank you for your review, could you please tell me when etcd |
Yes, please update https://github.com/etcd-io/etcd/blob/main/CHANGELOG/CHANGELOG-3.5.md#v3515-tbd |
|
[3.5] Support multiple values for allowed client and peer TLS identities
Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.
cherry pick #18015 to release-3.5