Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plan to release etcd v3.5.15 #18247

Closed
4 tasks done
ivanvc opened this issue Jun 28, 2024 · 20 comments
Closed
4 tasks done

Plan to release etcd v3.5.15 #18247

ivanvc opened this issue Jun 28, 2024 · 20 comments
Assignees
Labels
area/security priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. type/feature

Comments

@ivanvc
Copy link
Member

ivanvc commented Jun 28, 2024

What would you like to be added?

The etcd patch release criteria has been met for our release-3.5 stable release branch so we should release v3.5.15.

The list of commits included since the previous release is: v3.5.14...release-3.5:

Work in progress CHANGELOG is: https://github.com/etcd-io/etcd/blob/main/CHANGELOG/CHANGELOG-3.5.md#v3515-tbd

List of pull requests we still need to backport from main to release-3.5 before the patch release is issued:

Why is this needed?

Regular patch releases are vital to ensure our users have bug-free and secure software.

@jmhbnz jmhbnz added the priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. label Jun 28, 2024
@ivanvc
Copy link
Member Author

ivanvc commented Jun 28, 2024

After a sweep of fixes merged in the main branch after 3.5.14, I found these two potential backports:

Do we want to backport any of these?

I would appreciate another pair of eyes to do another pass.

I also volunteer to be a shadow for this release :)

@jmhbnz
Copy link
Member

jmhbnz commented Jun 28, 2024

@spzala or @wenjiaswe did either of you want to lead this release? If not I am happy to volunteer as release lead.

Do we want to backport any of these?

Will do some review soon, we also need to take a close look at recent bug reports and see if anything needs to be included: https://github.com/etcd-io/etcd/issues?q=is%3Aissue+label%3Atype%2Fbug+created%3A%3E%3D2024-04-30

@ivanvc
Copy link
Member Author

ivanvc commented Jun 29, 2024

We may want to hold the release after 7/2, as according to SIG-release's email

There is a Go update being released on 07/02

I do see some outstanding changes in the Go Release Dashboard. But I don't know how to check when the version will be released, and I'm not sure if it will come with another vulnerability fix.

@wenjiaswe
Copy link
Contributor

@jmhbnz Yes, I am happy to do the release. It's a short week in US, maybe I can do it next week?

@jmhbnz
Copy link
Member

jmhbnz commented Jul 1, 2024

@jmhbnz Yes, I am happy to do the release. It's a short week in US, maybe I can do it next week?

SGTM - So release team will be:

Github handle Role
@jmhbnz Release advisor
@wenjiaswe Release lead
@ivanvc Release shadow

/assign @wenjiaswe, @ivanvc, @jmhbnz

@ivanvc
Copy link
Member Author

ivanvc commented Jul 3, 2024

Would you guys be available Monday, July 8th, at 11 a.m. PT? I'll be out next week starting Tuesday, so I won't be available if you want to schedule it for later that day, which is fine by me, we could see if someone else wants to shadow :)

@wenjiaswe
Copy link
Contributor

@ivanvc @jmhbnz I will discuss with you two on chat. If anyone else interested in shadowing, please ping me in slack: wenjiaswe

@ivanvc
Copy link
Member Author

ivanvc commented Jul 5, 2024

@jmhbnz, after updating Go to address vulnerabilities (#18269), I think we now can release 3.4.34, right?

@jmhbnz
Copy link
Member

jmhbnz commented Jul 5, 2024

@jmhbnz, after updating Go to address vulnerabilities (#18269), I think we now can release 3.4.34, right?

What is the CVE score? NIST don't list it yet https://nvd.nist.gov/vuln/detail/CVE-2024-24791. Our patch release criteria is 7.5 https://github.com/etcd-io/etcd/blob/main/Documentation/contributor-guide/release.md#patch-release-criteria but I'm not opposed to start organising 3.4.34 anyway once this release is done.

@ivanvc
Copy link
Member Author

ivanvc commented Jul 5, 2024

What is the CVE score? NIST don't list it yet https://nvd.nist.gov/vuln/detail/CVE-2024-24791. Our patch release criteria is 7.5

That's a good point. I think there's no rush, and ultimately, there are no other outstanding changes for 3.4 other than the Go update.

@jmhbnz jmhbnz pinned this issue Jul 5, 2024
@ivanvc
Copy link
Member Author

ivanvc commented Jul 6, 2024

Will do some review soon, we also need to take a close look at recent bug reports and see if anything needs to be included: https://github.com/etcd-io/etcd/issues?q=is%3Aissue+label%3Atype%2Fbug+created%3A%3E%3D2024-04-30

I reviewed these and couldn't find anything that caught my eye.
Do we want to backport any of #18247 (comment)?

@jmhbnz
Copy link
Member

jmhbnz commented Jul 6, 2024

I reviewed these and couldn't find anything that caught my eye. Do we want to backport any of #18247 (comment)?

Have raised backport proposals for both:

@bearpaws
Copy link

Are we still expecting the 3.5.15 release this week? Thanks.

@ivanvc
Copy link
Member Author

ivanvc commented Jul 19, 2024

We have scheduled this release for today, Friday, July 19th, at 1 pm PT.

@wenjiaswe
Copy link
Contributor

3.5.15 has been published: https://github.com/etcd-io/etcd/releases/tag/v3.5.15

@wenjiaswe
Copy link
Contributor

Improvement to do before 3.5.16:

  • Free space check: make sure you have at least 5GB
  • Add in the doc step 5: before publish, ensure the right tag is selected (@wenjiaswe to add to the doc)
  • when sending email to etcd-dev, make sure the pending email is approved by one of the approvers (maintainers)

wenjiaswe added a commit that referenced this issue Jul 20, 2024
Update release.md based on 3.5.15 release: #18247 (comment)
wenjiaswe added a commit that referenced this issue Jul 20, 2024
Update release.md based on 3.5.15 release: #18247 (comment)

Signed-off-by: Wenjia Zhang <wenjiazhang@google.com>
@ahrtr
Copy link
Member

ahrtr commented Jul 23, 2024

PLease also update the release date, thx

https://github.com/etcd-io/etcd/blob/main/CHANGELOG/CHANGELOG-3.5.md#v3515-tbd

@ivanvc
Copy link
Member Author

ivanvc commented Jul 23, 2024

Please also update the release date, thx

Done in #18355.

wenjiaswe added a commit that referenced this issue Jul 31, 2024
Update release.md based on 3.5.15 release: #18247 (comment)

Signed-off-by: Wenjia Zhang <wenjiazhang@google.com>
wenjiaswe added a commit that referenced this issue Jul 31, 2024
wenjiaswe added a commit that referenced this issue Jul 31, 2024
Signed-off-by: Wenjia Zhang <wenjiazhang@google.com>
wenjiaswe added a commit that referenced this issue Jul 31, 2024
Update release.md based on 3.5.15 release: #18247 (comment)

Signed-off-by: Wenjia Zhang <wenjiazhang@google.com>
@ahrtr
Copy link
Member

ahrtr commented Aug 1, 2024

All done.

@ahrtr ahrtr closed this as completed Aug 1, 2024
@ahrtr ahrtr unpinned this issue Aug 1, 2024
@ahrtr
Copy link
Member

ahrtr commented Aug 1, 2024

thx all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/security priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. type/feature
Development

No branches or pull requests

5 participants