-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CHANGELOG/CHANGELOG-3.5.md: update changelog for gRPC metadata printing #18317
CHANGELOG/CHANGELOG-3.5.md: update changelog for gRPC metadata printing #18317
Conversation
Hi @mohamedawnallah. Thanks for your PR. I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files
... and 14 files with indirect coverage changes @@ Coverage Diff @@
## main #18317 +/- ##
==========================================
- Coverage 69.00% 68.89% -0.12%
==========================================
Files 417 417
Lines 35332 35333 +1
==========================================
- Hits 24380 24341 -39
- Misses 9540 9576 +36
- Partials 1412 1416 +4 Continue to review full report in Codecov by Sentry.
|
2601d41
to
53930d7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks
53930d7
to
215a2ed
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor typo to fix before we merge.
In this commit, we update the changelog for gRPC metadata printing in release 3.5 which is mainly a backport from PR etcd-io#18312. Signed-off-by: Mohamed Awnallah <mohamedmohey2352@gmail.com>
215a2ed
to
163917d
Compare
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahrtr, jmhbnz, mohamedawnallah The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
In this commit, we update the changelog for gRPC metadata printing in release 3.5 which is mainly a backport from PR #18312.