Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3.5] client/v3/watch.go: use fmt go pkg for gRPC metadata map printing #18312

Merged
merged 2 commits into from
Jul 13, 2024
Merged

[3.5] client/v3/watch.go: use fmt go pkg for gRPC metadata map printing #18312

merged 2 commits into from
Jul 13, 2024

Conversation

mohamedawnallah
Copy link
Contributor

Description

This PR backports the changes from #18308 PR to the release-3.5 branch.

Issue

Addresses Issue #18303 in the backport release-3.5.

@k8s-ci-robot
Copy link

Hi @mohamedawnallah. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@mohamedawnallah mohamedawnallah changed the base branch from main to release-3.5 July 12, 2024 11:48
@mohamedawnallah
client/v3/watch.go: use fmt for metadata printing
b1fc94f 
Signed-off-by: Mohamed Awnallah <mohamedmohey2352@gmail.com>
@mohamedawnallah
client/v3/watch_test.go: test fmt metadata print
1bfca72 
Signed-off-by: Mohamed Awnallah <mohamedmohey2352@gmail.com>
Co-authored-by: Benjamin Wang <ahrtr>
@mohamedawnallah mohamedawnallah force-pushed the backport-3.5-fmtgRPCMetadata branch from 095eebe to 1bfca72 Compare July 12, 2024 11:51
@mohamedawnallah mohamedawnallah mentioned this pull request Jul 12, 2024
Merged
@ivanvc
Copy link
Member

ivanvc commented Jul 12, 2024

/retitle [3.5] client/v3/watch.go: use fmt go pkg for gRPC metadata map printing

@k8s-ci-robot k8s-ci-robot changed the title client/v3/watch.go: use fmt go pkg for gRPC metadata map printing (backport release-3.5) [3.5] client/v3/watch.go: use fmt go pkg for gRPC metadata map printing Jul 12, 2024
ahrtr
ahrtr approved these changes Jul 12, 2024
View reviewed changes
Copy link
Member

@ahrtr ahrtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks

@ivanvc
Copy link
Member

ivanvc commented Jul 12, 2024

/ok-to-test

jmhbnz
jmhbnz approved these changes Jul 12, 2024
View reviewed changes
Copy link
Member

@jmhbnz jmhbnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Thanks @mohamedawnallah

ivanvc
ivanvc approved these changes Jul 13, 2024
View reviewed changes
Copy link
Member

@ivanvc ivanvc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, @mohamedawnallah.

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ahrtr, ivanvc, jmhbnz, mohamedawnallah

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ahrtr ahrtr merged commit 4548f41 into etcd-io:release-3.5 Jul 13, 2024
27 checks passed
mohamedawnallah added a commit to mohamedawnallah/etcd that referenced this pull request Jul 13, 2024
@mohamedawnallah
CHANGELOG/CHANGELOG-3.5.md: update changelog
d71466d 
In this commit, we update the changelog for gRPC
metadata printing in release 3.5 which is mainly
a backport from PR etcd-io#18312.

Signed-off-by: Mohamed Awnallah <mohamedmohey2352@gmail.com>
@mohamedawnallah mohamedawnallah mentioned this pull request Jul 13, 2024
Merged
mohamedawnallah added a commit to mohamedawnallah/etcd that referenced this pull request Jul 13, 2024
@mohamedawnallah
CHANGELOG/CHANGELOG-3.5.md: update changelog
2601d41 
In this commit, we update the changelog for gRPC
metadata printing in release 3.5 which is mainly
a backport from PR etcd-io#18312.

Signed-off-by: Mohamed Awnallah <mohamedmohey2352@gmail.com>
mohamedawnallah added a commit to mohamedawnallah/etcd that referenced this pull request Jul 13, 2024
@mohamedawnallah
CHANGELOG/CHANGELOG-3.5.md: update changelog
53930d7 
In this commit, we update the changelog for gRPC
metadata printing in release 3.5 which is mainly
a backport from PR etcd-io#18312.

Signed-off-by: Mohamed Awnallah <mohamedmohey2352@gmail.com>
mohamedawnallah added a commit to mohamedawnallah/etcd that referenced this pull request Jul 14, 2024
@mohamedawnallah
CHANGELOG/CHANGELOG-3.5.md: update changelog
215a2ed 
In this commit, we update the changelog for gRPC
metadata printing in release 3.5 which is mainly
a backport from PR etcd-io#18312.

Signed-off-by: Mohamed Awnallah <mohamedmohey2352@gmail.com>
mohamedawnallah added a commit to mohamedawnallah/etcd that referenced this pull request Jul 14, 2024
@mohamedawnallah
CHANGELOG/CHANGELOG-3.5.md: update changelog
163917d 
In this commit, we update the changelog for gRPC
metadata printing in release 3.5 which is mainly
a backport from PR etcd-io#18312.

Signed-off-by: Mohamed Awnallah <mohamedmohey2352@gmail.com>
@ivanvc ivanvc mentioned this pull request Jul 15, 2024
Closed
4 tasks
ah8ad3 pushed a commit to ah8ad3/etcd that referenced this pull request Jul 23, 2024
@mohamedawnallah @ah8ad3
CHANGELOG/CHANGELOG-3.5.md: update changelog
cc59e2b 
In this commit, we update the changelog for gRPC
metadata printing in release 3.5 which is mainly
a backport from PR etcd-io#18312.

Signed-off-by: Mohamed Awnallah <mohamedmohey2352@gmail.com>
aneesh1 pushed a commit to DataDog/etcd that referenced this pull request Sep 24, 2024
@ahrtr @aneesh1
Merge pull request etcd-io#18312 from mohamedawnallah/backport-3.5-fm…
457f195 
…tgRPCMetadata

[3.5] client/v3/watch.go: use fmt go pkg for gRPC metadata map printing
@chaosi-zju chaosi-zju mentioned this pull request Nov 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmhbnz jmhbnz jmhbnz approved these changes

@ahrtr ahrtr ahrtr approved these changes

@ivanvc ivanvc ivanvc approved these changes

Assignees
No one assigned
Labels
area/contrib area/documentation area/etcdctl area/observability area/performance area/testing area/tooling github_actions Pull requests that update GitHub Actions code ok-to-test size/M
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mohamedawnallah @k8s-ci-robot @ivanvc @ahrtr @jmhbnz