mvcc/*_test.go: should not use duplicate revision.Main for one key #18321
Conversation
In commit [[1]], the newTestKeyIndex function creates one key with two
Revision{Main: 14} revisions. However, starting from version [[2]], etcd server
does not allow duplicate keys in a single transaction. This update to
newTestKeyIndex is to avoid confusion and ensure consistency with the
latest etcd server behavior.
REF:
[1]: etcd-io@be80d11
[2]: etcd-io#4376
Signed-off-by: Wei Fu <fuweid89@gmail.com>
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted filessee 29 files with indirect coverage changes @@ Coverage Diff @@
## main #18321 +/- ##
==========================================
+ Coverage 68.87% 68.95% +0.08%
==========================================
Files 417 417
Lines 35333 35333
==========================================
+ Hits 24334 24365 +31
+ Misses 9577 9556 -21
+ Partials 1422 1412 -10 Continue to review full report in Codecov by Sentry.
|
|
/retest |
|
Link to #18089 |
|
The first next step as mentioned in #18274 (comment) |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahrtr, fuweid, ivanvc, jmhbnz, siyuanfoundation The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Backport of etcd-io#18321 Signed-off-by: Wei Fu <fuweid89@gmail.com>
Backport of etcd-io#18321 Signed-off-by: Wei Fu <fuweid89@gmail.com>
fuweid
deleted the
mvcc-test/should-not-allow-duplicate-keys-in-one-txn
branch
Backport of etcd-io#18321 Signed-off-by: Wei Fu <fuweid89@gmail.com>
In commit [1], the newTestKeyIndex function creates one key with two Revision{Main: 14} revisions. However, starting from version [2], etcd server does not allow duplicate keys in a single transaction. This update to newTestKeyIndex is to avoid confusion and ensure consistency with the latest etcd server behavior.
REF:
Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.