etcdserver: reject v3 txns with duplicate put keys #4376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| // checkRequestPutKeys gives ErrDuplicateKey if the same key is put twice | ||
| func checkRequestPutKeys(reqs []*pb.RequestUnion) error { |
There was a problem hiding this comment.
we should not allow put then delete too, right?
There was a problem hiding this comment.
Right, will fix
|
Cannot sleep early recently for no reason. etcd night club formed. |
heyitsanthony
force-pushed
the
txn-no-duplicate-putkey
branch
from
a30c3ad
to
c0f74e4
Compare
|
all fixed ptal /cc @xiang90 |
|
LGTM |
|
ok merging on greenlight |
An API check to support PR etcd-io#4363; bad requests didn't return an error.
heyitsanthony
force-pushed
the
txn-no-duplicate-putkey
branch
from
185bc34
to
c5c5063
Compare
heyitsanthony
pushed a commit
that referenced
this pull request
Feb 2, 2016
etcdserver: reject v3 txns with duplicate put keys
fuweid
added a commit
to fuweid/etcd
that referenced
this pull request
Jul 14, 2024
In commit [[1]], the newTestKeyIndex function creates one key with two
Revision{Main: 14} revisions. However, starting from version [[2]], etcd server
does not allow duplicate keys in a single transaction. This update to
newTestKeyIndex is to avoid confusion and ensure consistency with the
latest etcd server behavior.
REF:
[1]: etcd-io@be80d11
[2]: etcd-io#4376
Signed-off-by: Wei Fu <fuweid89@gmail.com>
ah8ad3
pushed a commit
to ah8ad3/etcd
that referenced
this pull request
Jul 23, 2024
In commit [[1]], the newTestKeyIndex function creates one key with two
Revision{Main: 14} revisions. However, starting from version [[2]], etcd server
does not allow duplicate keys in a single transaction. This update to
newTestKeyIndex is to avoid confusion and ensure consistency with the
latest etcd server behavior.
REF:
[1]: etcd-io@be80d11
[2]: etcd-io#4376
Signed-off-by: Wei Fu <fuweid89@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An API check to support PR #4363; bad requests didn't return an error.