Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.4] Skip leadership check if the etcd instance is active processing heartbeats #18440

Merged
merged 1 commit into from
Aug 14, 2024

Conversation

ahrtr
Copy link
Member

@ahrtr ahrtr commented Aug 14, 2024

…beats

Signed-off-by: Benjamin Wang <benjamin.ahrtr@gmail.com>
@ahrtr ahrtr force-pushed the improve_leaseRenew_20240814_3.4 branch from 48f18ef to 9dee9b7 Compare August 14, 2024 16:00
Copy link
Member

@jmhbnz jmhbnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Thanks @ahrtr

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ahrtr, jmhbnz
Once this PR has been reviewed and has the lgtm label, please assign fanminshi for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ahrtr ahrtr merged commit 1956a47 into etcd-io:release-3.4 Aug 14, 2024
18 checks passed
@ahrtr ahrtr deleted the improve_leaseRenew_20240814_3.4 branch August 14, 2024 20:35
@ivanvc ivanvc mentioned this pull request Aug 22, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

3 participants