Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update changelog for the performance regression caused by ensureLeadership in leaseRenew #18441

Merged
merged 1 commit into from
Aug 14, 2024

Conversation

…rship in leaseRenew

Signed-off-by: Benjamin Wang <benjamin.ahrtr@gmail.com>
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.80%. Comparing base (c147425) to head (4343997).
Report is 2 commits behind head on main.

Current head 4343997 differs from pull request most recent head 4b8e784

Please upload reports for the commit 4b8e784 to get more accurate results.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

see 24 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #18441      +/-   ##
==========================================
- Coverage   68.85%   68.80%   -0.05%     
==========================================
  Files         420      420              
  Lines       35475    35475              
==========================================
- Hits        24425    24409      -16     
- Misses       9623     9640      +17     
+ Partials     1427     1426       -1     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c147425...4b8e784. Read the comment docs.

Copy link
Member

@jmhbnz jmhbnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Thanks @ahrtr

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, jmhbnz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ahrtr ahrtr merged commit 3aa56a7 into etcd-io:main Aug 14, 2024
47 checks passed
@ahrtr ahrtr deleted the improve_leaseRenew_20240814_changelog branch August 14, 2024 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants