Skip to content
This repository has been archived by the owner on Jun 3, 2024. It is now read-only.

schedule dencun on goerli #178

Merged
merged 3 commits into from
Jan 2, 2024
Merged

schedule dencun on goerli #178

merged 3 commits into from
Jan 2, 2024

Conversation

g11tech
Copy link
Contributor

@g11tech g11tech commented Dec 21, 2023

@etan-status
Copy link
Contributor

etan-status commented Dec 23, 2023

Proposing to make this repo the canonical one (over eth2-networks repo). Here a PR that makes this loadable from Nimbus (we need the block hash file):

etan-status added a commit to status-im/nimbus-eth2 that referenced this pull request Dec 23, 2023
The `eth2-networks` repo often receives metadata updates with a delay.
Switch to `goerli` repo to obtain the latest config (Dencun scheduling)
when it is updated. This is in line with how Sepolia / Holesky work.

- eth-clients/goerli#178
@rolfyone
Copy link

I could be wrong, but when i loaded it to teku we were missing all the deneb config:

# Deneb
# `2**7` (=128)
MAX_REQUEST_BLOCKS_DENEB: 128
# MAX_REQUEST_BLOCKS_DENEB * MAX_BLOBS_PER_BLOCK
MAX_REQUEST_BLOB_SIDECARS: 768
# `2**12` (= 4096 epochs, ~18 days)
MIN_EPOCHS_FOR_BLOB_SIDECARS_REQUESTS: 4096
# `6`
BLOB_SIDECAR_SUBNET_COUNT: 6
# `uint64(6)`
MAX_BLOBS_PER_BLOCK: 6

and the validator cycle change:

# [New in Deneb:EIP7514] 2**3 (= 8)
MAX_PER_EPOCH_ACTIVATION_CHURN_LIMIT: 8

Is everyone else getting these fields from elsewhere?

rolfyone added a commit to rolfyone/teku that referenced this pull request Dec 23, 2023
The pr was missing some config I think, I had to add a bunch of Deneb fields that were flagged missing in tests.

Ref. eth-clients/goerli#178

Signed-off-by: Paul Harris <paul.harris@consensys.net>
@etan-status
Copy link
Contributor

The fields are initialized from the mainnet preset (the config refers to the preset to load defaults from at the start)

@g11tech
Copy link
Contributor Author

g11tech commented Dec 31, 2023

@rolfyone yea we generally keep adding fields to our mainnet config in codebase and any provided config overrides the mainnet fields (or the minimal one depends on the loaded preset), @etan-status these fields (https://github.com/ethereum/consensus-specs/blob/dev/configs/mainnet.yaml#L144) are separate from the preset (https://github.com/ethereum/consensus-specs/blob/dev/presets/mainnet/deneb.yaml) so i guess they should be added here

@parithosh what is the strategy for generating and keep the configs for testnets? all fields are generated and maintained or only those which are overriden?

@parithosh
Copy link
Member

parithosh commented Dec 31, 2023

Newer testnets are all generated from here: https://github.com/ethpandaops/ethereum-genesis-generator/blob/master/config-example/cl/config.yaml

The older ones like goerli are just manually updated, so we try to keep it up to date with: https://github.com/ethereum/consensus-specs/blob/dev/configs/mainnet.yaml . Its extremely likely that the last time we updated it was during the withdrawals fork. Definitely worth updating the PR to include all the fields in the config explicitly.

@rolfyone
Copy link

rolfyone commented Jan 2, 2024

LGTM!

@terencechain terencechain merged commit 6522ac6 into eth-clients:main Jan 2, 2024
etan-status added a commit to status-im/nimbus-eth2 that referenced this pull request Jan 2, 2024
The `eth2-networks` repo often receives metadata updates with a delay.
Switch to `goerli` repo to obtain the latest config (Dencun scheduling)
when it is updated. This is in line with how Sepolia / Holesky work.

- eth-clients/goerli#178
zah pushed a commit to status-im/nimbus-eth2 that referenced this pull request Jan 3, 2024
The `eth2-networks` repo often receives metadata updates with a delay.
Switch to `goerli` repo to obtain the latest config (Dencun scheduling)
when it is updated. This is in line with how Sepolia / Holesky work.

- eth-clients/goerli#178
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants