Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

load Goerli metadata from goerli repo #5680

Merged
merged 2 commits into from
Jan 2, 2024
Merged

Conversation

etan-status
Copy link
Contributor

The eth2-networks repo often receives metadata updates with a delay. Switch to goerli repo to obtain the latest config (Dencun scheduling) when it is updated. This is in line with how Sepolia / Holesky work.

The `eth2-networks` repo often receives metadata updates with a delay.
Switch to `goerli` repo to obtain the latest config (Dencun scheduling)
when it is updated. This is in line with how Sepolia / Holesky work.

- eth-clients/goerli#178
@etan-status
Copy link
Contributor Author

@tersec
Copy link
Contributor

tersec commented Dec 23, 2023

Assuming the changes are currently synced between eth2-networks and goerli repos, this seems reasonable. If nothing else, within a few months, probably nimbus-eth2 will in accordance with https://blog.ethereum.org/2023/11/30/goerli-lts-update drop support for Goerli/Prater altogether, regardless of from which repo.

One somewhat nice aspect now is that it only fetches eth2-networks, not eth2-networks and goerli, on recursive clone/make update/git submodules update/etc. So functionally, this adds to download time and clone storage space requirements for the sake of consistency with Holesky.

If eth-clients/eth2-networks#92 is merged, that would restore the status quo ante, by making a (shallow) submodule clone of eth2-networks less bandwidth and disk-intensive by almost exactly the same amount as adding goerli increases it, for no net changes.

Also, it is more consistent with Holesky, but it's less consistent with mainnet. If mainnet had also its own updated/maintained repo, that then using both that and the goerli repo as here would be ideal. But https://github.com/eth-clients/eth2-mainnet exists and "has been archived by the owner on May 26, 2021. It is now read-only", so that would have to be recreated.

Certainly, not having two out-of-sync copies of the Goerli/Prater network configuration is better, regardless.

@etan-status
Copy link
Contributor Author

Yeah, regardless of deprecation, we just need to pick the repo that has the correct DENCUN_FORK_EPOCH set. Which, right now, is only planned for goerli (open PRs)

Copy link

github-actions bot commented Dec 23, 2023

Unit Test Results

         9 files  ±0    1 098 suites  ±0   27m 15s ⏱️ -46s
  3 965 tests ±0    3 618 ✔️ ±0  347 💤 ±0  0 ±0 
16 090 runs  ±0  15 692 ✔️ ±0  398 💤 ±0  0 ±0 

Results for commit e52557e. ± Comparison against base commit 0302261.

♻️ This comment has been updated with latest results.

@etan-status etan-status enabled auto-merge (squash) January 2, 2024 14:58
@etan-status etan-status merged commit af63291 into unstable Jan 2, 2024
11 checks passed
@etan-status etan-status deleted the dev/etan/bd-goerli branch January 2, 2024 15:15
zah pushed a commit that referenced this pull request Jan 3, 2024
The `eth2-networks` repo often receives metadata updates with a delay.
Switch to `goerli` repo to obtain the latest config (Dencun scheduling)
when it is updated. This is in line with how Sepolia / Holesky work.

- eth-clients/goerli#178
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants