-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to use sockets
instead of numa_domains
with pika's resource partitioner
#1180
Conversation
sockets
instead of numa_domains
with pika's resource partitioner
cscs-ci run |
This will keep failing in CI for now because spack/spack#46062 is required to find Boost properly with pika 0.28.0. Once spack/spack#46207 is merged I'll update the spack commit here. |
Note that this breakage is another great reason to move the MPI pool initialization into pika with #1125. |
Once I update the spack commit, it might make sense to make some CI configurations use older, fixed, versions of pika. Any objections or wishes for which pipelines should have older versions if any? |
cscs-ci run |
cscs-ci run |
90f5a8e
to
0b8c97f
Compare
cscs-ci run |
Conflict now in upstream spack.
- adds fmt/pika conflict - fixes header-only boost installation
cscs-ci run |
This is now ready for review. The disabled stdexec pipelines are tracked in #1184. The clang-based stdexec pipelines are still enabled, so we do still have some stdexec tests running even with the GCC ones disabled for now. |
…source partitioner (#1180)
Fixes a breaking change introduced in pika 0.28.0.
I've taken the opportunity to fix a TODO that required a newer version of pika: check whether pika has been initialized before accessing the resource partitioner.