Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to use sockets instead of numa_domains with pika's resource partitioner #1180

Merged
merged 18 commits into from
Sep 16, 2024

Conversation

msimberg
Copy link
Collaborator

@msimberg msimberg commented Sep 5, 2024

Fixes a breaking change introduced in pika 0.28.0.

I've taken the opportunity to fix a TODO that required a newer version of pika: check whether pika has been initialized before accessing the resource partitioner.

@msimberg msimberg self-assigned this Sep 5, 2024
ci/docker/common.yaml Outdated Show resolved Hide resolved
@msimberg msimberg changed the title Update to use sockets instead of numa_domains with pika's resource partitioner Update to use sockets instead of numa_domains with pika's resource partitioner Sep 5, 2024
@msimberg msimberg requested review from rasolca and albestro September 5, 2024 08:14
@msimberg
Copy link
Collaborator Author

msimberg commented Sep 5, 2024

cscs-ci run

@msimberg
Copy link
Collaborator Author

msimberg commented Sep 5, 2024

This will keep failing in CI for now because spack/spack#46062 is required to find Boost properly with pika 0.28.0. Once spack/spack#46207 is merged I'll update the spack commit here.

@msimberg
Copy link
Collaborator Author

msimberg commented Sep 5, 2024

Note that this breakage is another great reason to move the MPI pool initialization into pika with #1125.

@msimberg
Copy link
Collaborator Author

msimberg commented Sep 5, 2024

Once I update the spack commit, it might make sense to make some CI configurations use older, fixed, versions of pika. Any objections or wishes for which pipelines should have older versions if any?

@msimberg
Copy link
Collaborator Author

msimberg commented Sep 5, 2024

cscs-ci run

@msimberg
Copy link
Collaborator Author

msimberg commented Sep 6, 2024

cscs-ci run

@msimberg
Copy link
Collaborator Author

msimberg commented Sep 6, 2024

cscs-ci run

Conflict now in upstream spack.
- adds fmt/pika conflict
- fixes header-only boost installation
@msimberg
Copy link
Collaborator Author

cscs-ci run

@msimberg msimberg requested a review from rasolca September 10, 2024 11:13
@msimberg
Copy link
Collaborator Author

This is now ready for review. The disabled stdexec pipelines are tracked in #1184. The clang-based stdexec pipelines are still enabled, so we do still have some stdexec tests running even with the GCC ones disabled for now.

@rasolca rasolca merged commit 36c4cfa into eth-cscs:master Sep 16, 2024
5 checks passed
github-actions bot pushed a commit that referenced this pull request Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants