-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reenable stdexec GCC CI configurations #1187
Conversation
cscs-ci run |
e128eda
to
ba33641
Compare
I've marked this ready for review. The workaround is the same as before. The smallest reproducer I've found so far is: #include <pika/execution.hpp>
auto helper = [](auto f) {
return stdexec::let_value(stdexec::just(f), [](auto f) noexcept {
return f() |
pika::execution::experimental::drop_value() |
stdexec::then([]{});
});
};
auto algo() {
return helper([]() noexcept {
return helper([]() noexcept { return stdexec::just(); });
});
} i.e. involves both pika and stdexec. Further investigation is going to take quite a bit longer so I would prefer going with the workaround right now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks a lot!
cscs-ci run |
Fixes #1184. Based on #1180, since that disables the stdexec CI.
This is a workaround to avoid compilation errors like:
This is triggered by the two nested
withTemporaryTiles
used inall_reduce.h
(DLA-Future/include/dlaf/communication/kernels/internal/all_reduce.h
Lines 51 to 99 in a64c822