Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reenable stdexec GCC CI configurations #1187

Merged
merged 2 commits into from
Sep 23, 2024
Merged

Reenable stdexec GCC CI configurations #1187

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b9ff228
Work around stdexec let_value bug
msimberg Sep 16, 2024
ba33641
Reenable GCC 11/stdexec CI configurations
msimberg Sep 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions ci/.gitlab-ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,8 @@ include:
- local: 'ci/cpu/clang15_release.yml'
- local: 'ci/cpu/clang16_release.yml'
- local: 'ci/cpu/clang18_release.yml'
# https://github.com/eth-cscs/DLA-Future/issues/1184
# - local: 'ci/cpu/gcc11_release_stdexec.yml'
# - local: 'ci/cpu/gcc11_debug_stdexec.yml'
- local: 'ci/cpu/gcc11_release_stdexec.yml'
- local: 'ci/cpu/gcc11_debug_stdexec.yml'
- local: 'ci/cpu/gcc12_release_cxx20.yml'
- local: 'ci/cpu/gcc13_codecov.yml'
- local: 'ci/cpu/gcc13_release.yml'
Expand Down
5 changes: 3 additions & 2 deletions include/dlaf/communication/kernels/internal/all_reduce.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,8 +80,9 @@ template <Device DCommIn, Device DCommOut, class T, Device DIn, Device DOut>
// written into the output tile instead). The reduction is explicitly done
// on CPU memory so that we can manage potential asynchronous copies between
// CPU and GPU. A reduction requires contiguous memory.
return withTemporaryTile<DCommIn, CopyToDestination::Yes, CopyFromDestination::No,
RequireContiguous::Yes>(std::move(tile_in), std::move(all_reduce));
return pika::execution::experimental::make_unique_any_sender(
withTemporaryTile<DCommIn, CopyToDestination::Yes, CopyFromDestination::No,
RequireContiguous::Yes>(std::move(tile_in), std::move(all_reduce)));
};

#if !defined(DLAF_WITH_MPI_GPU_AWARE)
Expand Down
Loading