Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Basic support for different media types #248

Closed
wants to merge 5 commits into from
Closed

Basic support for different media types #248

wants to merge 5 commits into from

Conversation

0ip
Copy link
Member

@0ip 0ip commented Nov 28, 2011

By typing any url, linking to an image, music file or video - the media immediately appears.
To disable automatic detection, just append a single #.

Example http://pad.factor.cc/p/JhJVKpKGe0

@markreg
Copy link

markreg commented Nov 28, 2011

This is so awesome.

@Pita
Copy link
Contributor

Pita commented Nov 28, 2011

Great work!

Can we change that so it works with youtube and vimeo links too? Mazybe also twitpic and imgur

And it would be great if we can add something so the user sees which link belongs to which video/image

@0ip
Copy link
Member Author

0ip commented Nov 28, 2011

Successfully added on my to-do list ;)

@0ip
Copy link
Member Author

0ip commented Nov 29, 2011

Oh I hate Flash... :[

@Pita
Copy link
Contributor

Pita commented Nov 29, 2011

afaik youtube is using iframes to embed videos. If thats the reason why you hate flash

@markreg
Copy link

markreg commented Nov 29, 2011

Plus how will it work on iDevices...

Also 0ip, would iy be possible for you to implement inserting tavles via a grid-selection system (kind of like in MS Word). Also I had posted this in a different issue but I feel that covering the text with a color inhibits the readability of the text to some exteny and wqs wondering if you could make a patch to add an api option to switch off automatic highlighting of the text and instead just have a traveling tooltip type-of-box that is always above the user's cursor and simply has the user's name inside the tooltip with the user's "identifying color" the color of the toolip. This is basically what Google's document processor does.

@0ip
Copy link
Member Author

0ip commented Nov 29, 2011

Updated example
odd: works in Chrome but not in Firefox...

afaik youtube is using iframes to embed videos. If thats the reason why you hate flash

yep - that was one of my reasons ;)

→ http://occupyflash.org/

@markreg
Disabling colors already work: http://pad.factor.cc/p/holymoly?noColors=true
I have to think about this tooltip ;)
However, that's OT.

@crash-dive
Copy link

I was testing this out and it caused the pad to hang a few times in chrome. The problem seems to be related to when you try and delete the url of a youtube video you have added.

However I could not get it to happen everytime, so I will wait until you make some more changes and have another go.

@0ip
Copy link
Member Author

0ip commented Nov 29, 2011

Thanks for testing.
Only YouTube/Vimeo videos are affected and that's due to overlapping iframe's.
I'll look into the exact matter tomorrow. :)

@markreg
Copy link

markreg commented Dec 1, 2011

I just tried this in firefox 8.0 and I can't see the youtube video within the pad. It's just shown as a black box.

Also whenever I try to resize or move the image it just goes back to the previous state and doesn't allow me to resize or move it.

@Wikinaut
Copy link
Contributor

Wikinaut commented Dec 1, 2011

@0ip

What browser/s do you use for developing and testing your enhancement ?
Should be Firefox, Chrome, IE8 and, if possible, IE9. In my view (I don't have IE9 available)

@Pita
Copy link
Contributor

Pita commented Dec 2, 2011

@markred @0ip imho there is no need for resizing. Or at least not in this step

@0ip
Copy link
Member Author

0ip commented Dec 2, 2011

@Wikinaut You forgot Opera and I won't test something in IE8.

Regarding the Firefox issue: I don't know what's wrong. According to Firebug, syntax is ok and the log says that some variables are missing, but in YouTube's and Vimeo's embedding pages (which is, of course, odd, since it works in a single html with the same syntax as used in epl but without any problems...).

Do we really need YT/V support?

@markreg
Copy link

markreg commented Dec 2, 2011

Is there a bug when moving images as well, however? Also, I realize that resizing isn't at the top of the priority lit but it would be nice if we can resize images.

@Pita
Copy link
Contributor

Pita commented Dec 2, 2011

@0ip The normal user can't see the difference between a a twitpic link and a link directly to an image. The same problem is with videos, its even bigger there. So Youtube support would be very helpful.

@0ip
Copy link
Member Author

0ip commented Dec 2, 2011

Alright.

I tested this weird thing again using IE9 + Opera 11.60 + Chrome 17 and it works.
So it must be a Firefox-related bug.

@markreg
This resizing function is built-in since FF5 or 6.
If you want to move images, move the link.

@markreg
Copy link

markreg commented Dec 2, 2011

When I attempt to resize any image it jumps back to the original size.

If firefox is the only browser to have this supposed resizing capability then other browsers will not be able to resize at all?

@0ip
Copy link
Member Author

0ip commented Dec 2, 2011

I guess no.

When I attempt to resize any image it jumps back to the original size.

Of course: your 'resize' is only local.

@markreg
Copy link

markreg commented Dec 8, 2011

Is this going to be merged into EP master branch or are there some kinks that need to be worked on still?

@0ip
Copy link
Member Author

0ip commented Dec 8, 2011

Flash is a bit tricky on Firefox. It doesn't work yet but I don't know how to fix it.

@markreg
Copy link

markreg commented Dec 9, 2011

As far as the future is concerned. Flash is basically dead. Personally I think perfecting image support is the best thing for EP-lite right now. Features like dragging and moving images and the ability to upscale or downscale added images is a very useful and beneficial feature for adding image graphs and charts.

@0ip
Copy link
Member Author

0ip commented Dec 9, 2011

Pita insists on Youtube + Vimeo support. ;)
HTML5 ftw

@Pita
Copy link
Contributor

Pita commented Dec 9, 2011

Flash might be dead, but Youtube isn't. But if this is such big problem we should at least implement support for imgur and twitpic

@0ip
Copy link
Member Author

0ip commented Dec 9, 2011

IE is supported and that's the main point.

@yadutaf
Copy link

yadutaf commented Dec 11, 2011

I just got an idea about this extension :

Drag & Drop moving/resizing are not supported and this might look non-intuitive to our users. But, this idea of automatically generate a preview is really great !

Could we imagine a design option to display the embedded media in a side pane, an overlay or anything showing it's not directly part of the body but still referenced in the body ? This is a bit like twitter does when you have links to images/videos embedded inside your tweets.

What do you think ?

@Pita
Copy link
Contributor

Pita commented Dec 11, 2011

Btw, how will this look like at the timeslider and htmlexport?

@0ip
Copy link
Member Author

0ip commented Dec 11, 2011

@jtlebi Good idea. It's @Pita's decision.
For now, it's planned for version 1.2 to enable/disable media detection globally in a menu for several options like monospace, authorcolors, password protection etc.

@Pita Media is neither shown in the slider nor in exported documents.

@markreg
Copy link

markreg commented Dec 12, 2011

Personally, I think image media should have the ability to export in documents if possible.

@JohnMcLear
Copy link
Member

@Pita -- Afaik you are also working on this, should I wait for a commit/pull request from you before proceeding any further?

@0ip 0ip closed this Jan 12, 2012
@tschweitzer
Copy link

Will this feature go into the main branch? As far as I can see, it hasn't been merged, right?

@Pita
Copy link
Contributor

Pita commented Jan 24, 2012

@tschweitzer yeah, cause @0ip said his commits were too dirty

@tschweitzer
Copy link

So will @0ip clean up his commits and then the changes go into the main branch? Or will you @Pita re-implement a similar feature? I'd love to have this in etherpad.

@0ip
Copy link
Member Author

0ip commented Jan 25, 2012

@0ip waits until @Pita finished plugin support. :P
But even then it's doubtful whether I'll rework the code.

@Miserlou
Copy link

Miserlou commented Feb 4, 2013

What happened to this? Is there a plugin for image support?

@JohnMcLear
Copy link
Member

TLDR; Basic image support yes. https://npmjs.org/package/ep_previewimages

Advanced image support no. But if I can get some sponsorship or funding then I'd be able to continue my dev

muxator added a commit that referenced this pull request Oct 20, 2019
@muxator
dependencies: upgrade npm 6.10.3 -> 6.12.0
8e6bca4 
This upgrade should be backward compatible, but still suffers form major
vulnerabilities in its https-proxy-agent transitive dependency (see
https://www.npmjs.com/advisories/1184).

Changelog:
- https://github.com/npm/cli/releases

6.12.0 (2019-10-08):
    Now npm ci runs prepare scripts for git dependencies, and respects the
    --no-optional argument. Warnings for engine mismatches are printed again.
    Various other fixes and cleanups.

    BUG FIXES
    890b245dc #252 ci: add dirPacker to options (@claudiahdz)
    f3299acd0 #257 npm.community#4792 warn message on engine mismatch
                   (@ruyadorno)
    bbc92fb8f #259 npm.community#10288 Fix figgyPudding error in npm token
                   (@benblank)
    70f54dcb5 #241 doctor: Make OK more consistent (@gemal)

    FEATURES
    ed993a29c #249 Add CI environment variables to user-agent (@isaacs)
    f6b0459a4 #248 Add option to save package-lock without formatting Adds a new
                   config --format-package-lock, which defaults to true.
                   (@bl00mber)

DEPENDENCIES
    0ca063c5d npm-lifecycle@3.1.4:
        fix: filter functions and undefined out of makeEnv (@isaacs)
    5df6b0ea2 libcipm@4.0.4:
        fix: pack git directories properly (@claudiahdz)
        respect no-optional argument (@cruzdanilo)
    7e04f728c tar@4.4.12
    5c380e5a3 stringify-package@1.0.1 (@isaacs)
    62f2ca692 node-gyp@5.0.5 (@isaacs)
    0ff0ea47a npm-install-checks@3.0.2 (@isaacs)
    f46edae94 hosted-git-info@2.8.5 (@isaacs)

TESTING
    44a2b036b #262 fix root-ownership race conditions in meta-test (@isaacs)

6.11.3 (2019-09-03):
    Fix npm ci regressions and npm outdated depth.

    BUG FIXES
    235ed1d28 #239 Don't override user specified depth in outdated. Restores
                   ability to update packages using --depth as suggested by npm audit. (@G-Rath)
    1fafb5151 #242 npm.community#9586 Revert "install: do not descend into
                   directory deps' child modules" (@isaacs)
    cebf542e6 #243 npm.community#9720 ci: pass appropriate configs for file/dir
                   modes (@isaacs)

    DEPENDENCIES
    e5fbb7ed1 read-cmd-shim@1.0.4 (@claudiahdz)
    23ce65616 npm-pick-manifest@3.0.2 (@claudiahdz)

6.11.2 (2019-08-22):
    Fix a recent Windows regression, and two long-standing Windows bugs. Also,
    get CI running on Windows, so these things are less likely in the future.

    DEPENDENCIES
    9778a1b87 cmd-shim@3.0.3: Fix regression where shims fail to preserve exit
              code (@isaacs)
    bf93e91d8 npm-package-arg@6.1.1: Properly handle git+file: urls on Windows
              when a drive letter is included. (@isaacs)

    BUGFIXES
    6cc4cc66f escape args properly on Windows Bash Despite being bash, Node.js
              running on windows git mingw bash still executes child processes
              using cmd.exe. As a result, arguments in this environment need to
              be escaped in the style of cmd.exe, not bash. (@isaacs)

    TESTS
    291aba7b8 make tests pass on Windows (@isaacs)
    fea3a023a travis: run tests on Windows as well (@isaacs)

6.11.1 (2019-08-20):
    Fix a regression for windows command shim syntax.

    37db29647 cmd-shim@3.0.2 (@isaacs)

v6.11.0 (2019-08-20):
    A few meaty bugfixes, and introducing peerDependenciesMeta.

    FEATURES
    a12341088 #224 Implements peerDependenciesMeta (@arcanis)
    2f3b79bba #234 add new forbidden 403 error code (@claudiahdz)

    BUGFIXES
    24acc9fc8 and 45772af0d #217 npm.community#8863 npm.community#9327 do not
              descend into directory deps' child modules, fix shrinkwrap files
              that inappropriately list child nodes of symlink packages (@isaacs
              and @salomvary)
    50cfe113d #229 fixed typo in semver doc (@gall0ws)
    e8fb2a1bd #231 Fix spelling mistakes in CHANGELOG-3.md (@XhmikosR)
    769d2e057 npm/uid-number#7 Better error on invalid --user/--group configs.
              This addresses the issue when people fail to install binary
              packages on Docker and other environments where there is no
              'nobody' user. (@isaacs)
    8b43c9624 nodejs/node#28987 npm.community#6032 npm.community#6658
              npm.community#6069 npm.community#9323 Fix the regression where
              random config values in a .npmrc file are not passed to lifecycle
              scripts, breaking build processes which rely on them. (@isaacs)
    8b85eaa47 save files with inferred ownership rather than relying on SUDO_UID
              and SUDO_GID. (@isaacs)
    b7f6e5f02 Infer ownership of shrinkwrap files (@isaacs)
    54b095d77 #235 Add spec to dist-tag remove function (@theberbie)

    DEPENDENCIES
    dc8f9e52f pacote@9.5.7: Infer the ownership of all unpacked files in
              node_modules, so that we never have user-owned files in root-owned
              folders, or root-owned files in user-owned folders. (@isaacs)
    bb33940c3 cmd-shim@3.0.0:
        9c93ac3 #2 npm#3380 Handle environment variables properly (@basbossink)
        2d277f8 #25 #36 #35 Fix 'no shebang' case by always providing $basedir
                in shell script (@igorklopov)
        adaf20b #26 Fix $* causing an error when arguments contain parentheses
                (@satazor)
        49f0c13 #30 Fix paths for MSYS/MINGW bash (@dscho)
        51a8af3 #34 Add proper support for PowerShell (@ExE-Boss)
        4c37e04 #10 Work around quoted batch file names (@isaacs)
    a4e279544 npm-lifecycle@3.1.3 (@isaacs):
        fail properly if uid-number raises an error
    7086a1809 libcipm@4.0.3 (@isaacs)
    8845141f9 read-package-json@2.1.0 (@isaacs)
    51c028215 bin-links@1.1.3 (@isaacs)
    534a5548c read-cmd-shim@1.0.3 (@isaacs)
    3038f2fd5 gentle-fs@2.2.1 (@isaacs)
    a609a1648 graceful-fs@4.2.2 (@isaacs)
    f0346f754 cacache@12.0.3 (@isaacs)
    ca9c615c8 npm-pick-manifest@3.0.0 (@isaacs)
    b417affbf pacote@9.5.8 (@isaacs)

    TESTS
    b6df0913c #228 Proper handing of /usr/bin/node lifecycle-path test (@olivr70)
    aaf98e88c npm-registry-mock@1.3.0 (@isaacs)
@snyk-bot snyk-bot mentioned this pull request Dec 19, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@0ip @markreg @Pita @crash-dive @Wikinaut @yadutaf @JohnMcLear @tschweitzer @Miserlou