feat(cannon-native): The great MIPS64 migration #11388
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
clabby
requested review from
tynes,
mbaxter,
Inphi and
protolambda
and removed request for
tynes
clabby
force-pushed
the
cl/cannon-64bit
branch
from
d6d7354
to
1d9446e
Compare
|
This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 5 days. |
Inphi
reviewed
Sep 10, 2024
| @@ -37,7 +37,7 @@ func TestInstrumentedState_MultithreadedProgram(t *testing.T) { | |||
|
|
|||
| var stdOutBuf, stdErrBuf bytes.Buffer | |||
| us := NewInstrumentedState(state, oracle, io.MultiWriter(&stdOutBuf, os.Stdout), io.MultiWriter(&stdErrBuf, os.Stderr), testutil.CreateLogger()) | |||
| for i := 0; i < 1_000_000; i++ { | |||
| for i := 0; i < 2_000_000; i++ { | |||
There was a problem hiding this comment.
Does this mean running this test on 64-bit requires more steps?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
First man discovered fire, then why 64-bit CPU architectures are better than everything else.
This PR fully ports the native implementation of
cannonto MIPS64 - all tests beyond EVM differential tests are passing in thecannonpackage.Stack
op-programMIPS64 testsMerging
Merge #11404 into this branch first after reviews, then merge into
develop.