feat(cannon-contracts): MIPS64 conversion #11404
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
3 tasks
clabby
force-pushed
the
cl/cannon-sol-64bit
branch
from
b917e27
to
3c1fe85
Compare
clabby
commented
Aug 8, 2024
| @@ -386,7 +386,7 @@ func TestEVMFault(t *testing.T) { | |||
| nextPC uint64 | |||
| insn uint32 | |||
| }{ | |||
| {"illegal instruction", 0, 0xFF_FF_FF_FF}, | |||
There was a problem hiding this comment.
This is a valid SD instruction, fyi
clabby
force-pushed
the
cl/cannon-sol-64bit
branch
2 times, most recently
from
9b6764f
to
a701d24
Compare
clabby
force-pushed
the
cl/cannon-sol-64bit
branch
2 times, most recently
from
813bc78
to
21d6ff5
Compare
clabby
requested review from
sebastianst,
maurelian,
mbaxter,
Inphi and
protolambda
and removed request for
a team,
sebastianst and
maurelian
clabby
added
C-feature
benjaminion
reviewed
Aug 9, 2024
clabby
force-pushed
the
cl/cannon-sol-64bit
branch
from
21d6ff5
to
a6f8546
Compare
clabby
force-pushed
the
cl/cannon-64bit
branch
from
d6d7354
to
1d9446e
Compare
clabby
force-pushed
the
cl/cannon-sol-64bit
branch
from
a6f8546
to
a036ea4
Compare
|
This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 5 days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Converts
MIPS.sol&MIPS2.solto MIPS64.