Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

op-proposer: add l2 block height metrics #5189

Merged
merged 13 commits into from
Mar 22, 2023
Merged

op-proposer: add l2 block height metrics #5189

merged 13 commits into from
Mar 22, 2023

Conversation

shrimalmadhur
Copy link
Contributor

Description

  • Adding a new metric to op-proposer which emits the latest proposed block height

Tests

Please describe any tests you've added. If you've added no tests, or left important behavior untested, please explain why not.

Invariants

For changes to critical code paths, please list and describe the invariants or key security properties of your new or changed code.

Additional context

Add any other context about the problem you're solving.

Metadata

  • Fixes #[Link to Issue]

@changeset-bot
Copy link

changeset-bot bot commented Mar 17, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: 4551be4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@netlify
Copy link

netlify bot commented Mar 17, 2023 •
edited
Loading

✅ Deploy Preview for opstack-docs ready!

Name Link
🔨 Latest commit 4551be4
🔍 Latest deploy log https://app.netlify.com/sites/opstack-docs/deploys/641b52dfba98850008a460b5
😎 Deploy Preview https://deploy-preview-5189--opstack-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@shrimalmadhur shrimalmadhur force-pushed the madhur/op-proposer/add-l2-proposed-metrics branch 3 times, most recently from df536c0 to 8df017b Compare March 17, 2023 19:41
@shrimalmadhur shrimalmadhur marked this pull request as ready for review March 17, 2023 22:09
@shrimalmadhur shrimalmadhur requested a review from a team as a code owner March 17, 2023 22:09
@trianglesphere trianglesphere removed the request for review from tynes March 17, 2023 22:17
sebastianst
sebastianst requested changes Mar 20, 2023
View reviewed changes
Copy link
Member

@sebastianst sebastianst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome to see this coming!
As @trianglesphere remarked, please follow the pattern in #5167 and create a op-proposer/metrics package, with a noop implementation, etc.

Also please reuse the RefMetrics from op-service/metrics, like in the batcher metrics.

@shrimalmadhur
Copy link
Contributor Author

Awesome to see this coming! As @trianglesphere remarked, please follow the pattern in #5167 and create a op-proposer/metrics package, with a noop implementation, etc.

Also please reuse the RefMetrics from op-service/metrics, like in the batcher metrics.

Thanks @sebastianst and @trianglesphere for the guidance. I will make those changes similar to other packages and send out another revision. :)

@shrimalmadhur shrimalmadhur force-pushed the madhur/op-proposer/add-l2-proposed-metrics branch from 2d8587c to 43519a2 Compare March 20, 2023 22:03
sebastianst
sebastianst reviewed Mar 20, 2023
View reviewed changes
op-proposer/proposer/l2_output_submitter.go Outdated Show resolved Hide resolved
op-proposer/proposer/l2_output_submitter.go Outdated Show resolved Hide resolved
op-proposer/proposer/l2_output_submitter.go Outdated Show resolved Hide resolved
@shrimalmadhur shrimalmadhur requested review from trianglesphere and sebastianst and removed request for sebastianst and trianglesphere March 20, 2023 23:35
@shrimalmadhur
Copy link
Contributor Author

the main and bedrock-markdown are failing. But I don't see any PR related concern. 🤔

@shrimalmadhur
Copy link
Contributor Author

the main and bedrock-markdown are failing. But I don't see any PR related concern. 🤔

Hey @sebastianst @trianglesphere, how do I get these two failing tests to pass? want to make sure I make this PR merge ready.

@trianglesphere
Copy link
Contributor

bedrock-markdown test is failing because we do a link check & there is a dead link. That is why main is failing. We can ignore those tests. The rest of the tests which actually tests these changes are passing.

trianglesphere
trianglesphere approved these changes Mar 22, 2023
View reviewed changes
Copy link
Contributor

@trianglesphere trianglesphere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've confirmed that these work in the local devnet. Really nice work with this.

op-proposer/proposer/l2_output_submitter.go Outdated Show resolved Hide resolved
sebastianst
sebastianst approved these changes Mar 22, 2023
View reviewed changes
Copy link
Member

@sebastianst sebastianst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great now ✨ just that one import should be reordered.

@shrimalmadhur
Copy link
Contributor Author

Looks great now ✨ just that one import should be reordered.

perfect. just pushed both changes.

@mergify
Copy link
Contributor

mergify bot commented Mar 22, 2023

This PR has been added to the merge queue, and will be merged soon.

@mergify
Copy link
Contributor

mergify bot commented Mar 22, 2023

This PR is next in line to be merged, and will be merged as soon as checks pass.

1 similar comment
@mergify
Copy link
Contributor

mergify bot commented Mar 22, 2023

This PR is next in line to be merged, and will be merged as soon as checks pass.

@mergify mergify bot merged commit 8a308fc into ethereum-optimism:develop Mar 22, 2023
@mergify mergify bot removed the on-merge-train label Mar 22, 2023
@shrimalmadhur shrimalmadhur deleted the madhur/op-proposer/add-l2-proposed-metrics branch March 22, 2023 19:30
@seolaoh seolaoh mentioned this pull request Apr 27, 2023
Merged
@seolaoh seolaoh mentioned this pull request May 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0x00101010 0x00101010 0x00101010 left review comments

@sebastianst sebastianst sebastianst approved these changes

@trianglesphere trianglesphere trianglesphere approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@shrimalmadhur @trianglesphere @sebastianst @0x00101010