-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: apply the rest of Optimism v1.0.3 to Kroma #49
feat: apply the rest of Optimism v1.0.3 to Kroma #49
Conversation
Please update bindings! > cd bindings
> make more
> git diff
Changes not staged for commit:
(use "git add <file>..." to update what will be committed)
(use "git restore <file>..." to discard changes in working directory)
modified: bindings/kromaportal_more.go
modified: bindings/l1block_more.go
modified: bindings/systemconfig_more.go |
When I did like below, it gives outputs like above. # at packages/contracts
> npx hardhat compile
# at bindings
> make more Strangely, if I tried after removing |
I think you should delete your ./packages/contracts/cache folder, that is created before by # at ./packages/contracts
> yarn clean && npx hardhat compile
# at ./bindings
> make more or just simply # at ./
> make bindings |
6e9e3a7
to
3ea0b8d
Compare
@chokobole I reflected your comments and added a few new commits. |
3ea0b8d
to
b94e5ef
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Remarkable Changes
L2BlockTime
in e2e test: 2s to 1se2e/system_test.go
l2Syncer
→l2Sync
receiptSeq
→receiptProp
receiptVerif
→receiptSync
forge
,forge-std
forge
&forge-std
ethereum-optimism/optimism#5227op-e2e
op-chain-ops
packages/common-ts
packages/contracts
forge
&forge-std
ethereum-optimism/optimism#5227foundry
version in CTB README ethereum-optimism/optimism#5250docs