You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modularize the deposit resource config so that the source of truth is the SystemConfig contract. Now when users do a deposit, the OptimismPortal will make a call to the SystemConfig to get the params instead of reading them from constant variables. This will not impact the amount of gas users spend when depositing because it tracks the gas usage of the computations required to determine how much gas will be burnt and will burn the difference between the gas used to compute how much gas needs to be burnt and the actual amount of gas to be burnt.
A future PR may have the SystemConfig emit an event when the resource config is updated, this would allow the op-node to track the config for the deposit gas market pricing. Right now it would be a no-op, but in the future we could move the computations that currently happen on L1 to make the 1559 curve into the op-node so that the expensive calculations happen offchain and then allow the user to pay for the gas on L2.
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
![semgrep-app[bot]](https://avatars.githubusercontent.com/in/60555?s=60&v=4){kind=small}
tynes
force-pushed
the
fix/syscfg-prevent-low-gaslimit-3
branch
from
Description
Modularize the deposit resource config so that the source of truth is the
SystemConfigcontract. Now when users do a deposit, theOptimismPortalwill make a call to theSystemConfigto get the params instead of reading them from constant variables. This will not impact the amount of gas users spend when depositing because it tracks the gas usage of the computations required to determine how much gas will be burnt and will burn the difference between the gas used to compute how much gas needs to be burnt and the actual amount of gas to be burnt.A future PR may have the
SystemConfigemit an event when the resource config is updated, this would allow theop-nodeto track the config for the deposit gas market pricing. Right now it would be a no-op, but in the future we could move the computations that currently happen on L1 to make the 1559 curve into theop-nodeso that the expensive calculations happen offchain and then allow the user to pay for the gas on L2.Closes CLI-3704
TODOs