Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(devnet): Updated the L2 address to 9545 #5261

Merged
merged 2 commits into from
Mar 27, 2023

Conversation

qbzzt
Copy link
Contributor

@qbzzt qbzzt commented Mar 25, 2023

That's the correct value, not 8546 (which is, IIRC, websocket for L1).

@qbzzt qbzzt requested review from a team as code owners March 25, 2023 20:17
@qbzzt qbzzt requested a review from tynes March 25, 2023 20:17
@changeset-bot
Copy link

changeset-bot bot commented Mar 25, 2023

⚠️ No Changeset found

Latest commit: c2b1381

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@netlify
Copy link

netlify bot commented Mar 25, 2023

Deploy Preview for opstack-docs canceled.

Name Link
🔨 Latest commit c2b1381
🔍 Latest deploy log https://app.netlify.com/sites/opstack-docs/deploys/642134e9d871730007ddd4ca

Copy link
Contributor

@ajsutton ajsutton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Confirmed l2 geth port 8545 is exposed to the host as port 9545 so that's the port it should be accessed on.

@codecov
Copy link

codecov bot commented Mar 27, 2023

Codecov Report

Merging #5261 (4f1545b) into develop (b8e2fa5) will decrease coverage by 3.88%.
The diff coverage is n/a.

❗ Current head 4f1545b differs from pull request most recent head c2b1381. Consider uploading reports for the commit c2b1381 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #5261      +/-   ##
===========================================
- Coverage    39.78%   35.90%   -3.88%     
===========================================
  Files          381      226     -155     
  Lines        24198    19666    -4532     
  Branches       837        0     -837     
===========================================
- Hits          9628     7062    -2566     
+ Misses       13844    11916    -1928     
+ Partials       726      688      -38     
Flag Coverage Δ
bedrock-go-tests 35.90% <ø> (-0.08%) ⬇️
common-ts-tests ?
contracts-bedrock-tests ?
contracts-tests ?
core-utils-tests ?
dtl-tests ?
fault-detector-tests ?
sdk-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 161 files with indirect coverage changes

@mergify
Copy link
Contributor

mergify bot commented Mar 27, 2023

This PR has been added to the merge queue, and will be merged soon.

@mergify
Copy link
Contributor

mergify bot commented Mar 27, 2023

This PR is next in line to be merged, and will be merged as soon as checks pass.

1 similar comment
@mergify
Copy link
Contributor

mergify bot commented Mar 27, 2023

This PR is next in line to be merged, and will be merged as soon as checks pass.

@mergify mergify bot merged commit ca9f52a into develop Mar 27, 2023
@mergify mergify bot deleted the qbzzt/230325-devnode-l2-port branch March 27, 2023 06:19
@mergify mergify bot removed the on-merge-train label Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants