Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sdk: fix linting #5281

Merged
merged 1 commit into from
Mar 29, 2023
Merged

sdk: fix linting #5281

merged 1 commit into from
Mar 29, 2023

Conversation

tynes
Copy link
Contributor

@tynes tynes commented Mar 28, 2023

Description

Fix linting issues in the SDK. Ran yarn lint --fix and committed the diff.

Fix linting issues in the SDK. Ran `yarn lint --fix` and
committed the diff.
@tynes tynes requested a review from a team as a code owner March 28, 2023 21:35
@tynes tynes requested a review from roninjin10 March 28, 2023 21:35
@changeset-bot
Copy link

changeset-bot bot commented Mar 28, 2023

⚠️ No Changeset found

Latest commit: 6fcdeaa

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@netlify
Copy link

netlify bot commented Mar 28, 2023

Deploy Preview for opstack-docs canceled.

Name Link
🔨 Latest commit 6fcdeaa
🔍 Latest deploy log https://app.netlify.com/sites/opstack-docs/deploys/64235da6998d7b0008bb594b

Copy link
Member

@clabby clabby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, deferring to @roninjin10 for code owner approval

Copy link
Contributor

@refcell refcell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

packages/sdk/src/cross-chain-messenger.ts Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Mar 28, 2023

Codecov Report

Merging #5281 (6fcdeaa) into develop (1169788) will decrease coverage by 3.67%.
The diff coverage is 25.00%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #5281      +/-   ##
===========================================
- Coverage    39.95%   36.29%   -3.67%     
===========================================
  Files          360      253     -107     
  Lines        22979    21374    -1605     
  Branches       529      326     -203     
===========================================
- Hits          9181     7757    -1424     
+ Misses       13067    12921     -146     
+ Partials       731      696      -35     
Flag Coverage Δ
bedrock-go-tests 36.13% <ø> (-0.02%) ⬇️
common-ts-tests ?
contracts-bedrock-tests ?
contracts-tests ?
core-utils-tests ?
dtl-tests ?
fault-detector-tests 33.88% <ø> (ø)
sdk-tests 38.86% <25.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/sdk/src/cross-chain-messenger.ts 52.67% <25.00%> (ø)

... and 151 files with indirect coverage changes

@tynes tynes merged commit 0fad37e into develop Mar 29, 2023
@tynes tynes deleted the fix/lint-sdk branch March 29, 2023 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants