Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

contracts-bedrock: delete dead SystemConfig code #5279

Merged
merged 3 commits into from
Mar 29, 2023
Merged

contracts-bedrock: delete dead SystemConfig code #5279

merged 3 commits into from
Mar 29, 2023

Conversation

tynes
Copy link
Contributor

@tynes tynes commented Mar 28, 2023 •
edited
Loading

Description

The old constant for the min gas limit was left behind in the PR that made the min gas limit calculation safe. This commit deletes the constant and updates the tests to use the new method.

@tynes tynes requested a review from a team as a code owner March 28, 2023 20:54
@changeset-bot
Copy link

changeset-bot bot commented Mar 28, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: 34d0f8d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@netlify
Copy link

netlify bot commented Mar 28, 2023 •
edited
Loading

✅ Deploy Preview for opstack-docs canceled.

Name Link
🔨 Latest commit 34d0f8d
🔍 Latest deploy log https://app.netlify.com/sites/opstack-docs/deploys/6423e1c272b6380008624b6f

@tynes tynes requested review from clabby and maurelian March 28, 2023 20:54
refcell
refcell approved these changes Mar 28, 2023
View reviewed changes
Copy link
Contributor

@refcell refcell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gas savings, we love to see it

clabby
clabby approved these changes Mar 28, 2023
View reviewed changes
Copy link
Member

@clabby clabby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, pending CI checks

@clabby
Copy link
Member

clabby commented Mar 28, 2023

@tynes SDK lint checks were broken when #5277 was merged, do you mind resolving that here quickly?

tynes added a commit that referenced this pull request Mar 28, 2023
@tynes
contracts-bedrock: deploy implementations to goerli
4c71eed 
Includes all of the audit fixes. The upgrades via the `ProxyAdmin`
must all happen in a single atomic transaction to ensure there
are no errors due to inter-contract API changes.

This does not include the changes in
#5279.
The `SystemConfig` contract will need to be deployed again.
@tynes tynes mentioned this pull request Mar 28, 2023
Merged
@tynes
Copy link
Contributor Author

tynes commented Mar 28, 2023

Linting fix is here #5281

@tynes
contracts-bedrock: delete dead SystemConfig code
9235e96 
The old constant for the min gas limit was left behind
in the PR that made the min gas limit calculation safe.
This commit deletes the constant and updates the tests
to use the new method.
@tynes
op-bindings: regenerate
5303a14 
Include systemconfig bindings with new version
@tynes
Copy link
Contributor Author

tynes commented Mar 28, 2023

Rebuilt the bindings, this should fix the bindings build task

@mergify
Copy link
Contributor

mergify bot commented Mar 29, 2023

This PR has been added to the merge queue, and will be merged soon.

@mergify
Copy link
Contributor

mergify bot commented Mar 29, 2023

This PR is next in line to be merged, and will be merged as soon as checks pass.

1 similar comment
@mergify
Copy link
Contributor

mergify bot commented Mar 29, 2023

This PR is next in line to be merged, and will be merged as soon as checks pass.

@mergify mergify bot merged commit f51a572 into develop Mar 29, 2023
@mergify mergify bot deleted the fix/delete-dead-code branch March 29, 2023 07:20
@mergify mergify bot removed the on-merge-train label Mar 29, 2023
tynes added a commit that referenced this pull request Mar 29, 2023
@tynes
contracts-bedrock: deploy implementations to goerli
40c0421 
Includes all of the audit fixes. The upgrades via the `ProxyAdmin`
must all happen in a single atomic transaction to ensure there
are no errors due to inter-contract API changes.

This does not include the changes in
#5279.
The `SystemConfig` contract will need to be deployed again.
@seolaoh seolaoh mentioned this pull request May 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@refcell refcell refcell approved these changes

@clabby clabby clabby approved these changes

@smartcontracts smartcontracts Awaiting requested review from smartcontracts smartcontracts is a code owner automatically assigned from ethereum-optimism/contract-reviewers

@maurelian maurelian Awaiting requested review from maurelian

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tynes @clabby @refcell