-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Update op-e2e #5334
ci: Update op-e2e #5334
Conversation
|
✅ Deploy Preview for opstack-docs canceled.
|
0ade21e
to
dad8c5a
Compare
This fixes go based CI in several ways 1. Set test.parallel flag so it matches the actual amount of CPUs request 2. Add more calls to t.Parallel in op-e2e 3. Reduce the amount of blocks in TestBigL2Txs to reduce the test time.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #5334 +/- ##
===========================================
+ Coverage 38.67% 39.04% +0.37%
===========================================
Files 339 393 +54
Lines 25376 26206 +830
Branches 659 838 +179
===========================================
+ Hits 9814 10233 +419
- Misses 14818 15192 +374
- Partials 744 781 +37
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
amazing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Nice work. I've been running all the e2e tests locally a fair bit recently and IntelliJ runs them in parallel which has been quite reliable. I'd be surprised if there isn't some intermittency that turns up so we'll need to keep an eye out and fix it when it does, but it shouldn't be frequent from what I've seen running locally.
So far with the changes I've been making it's been more reliable this time (though I will watch our for flakes). I think the big improvement is specifying the parallelism. We may have been hitting this CircleCI issue where it doesn't appear to be setting the |
This PR has been added to the merge queue, and will be merged soon. |
This PR is next in line to be merged, and will be merged as soon as checks pass. |
Description
This fixes go based CI in several ways
CI Time for op-e2e goes from 16 min -> 4:30 min.
Metadata