Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

op-e2e: Separate engine API implementation from backend #5335

Merged
merged 2 commits into from
Apr 4, 2023

Conversation

ajsutton
Copy link
Contributor

@ajsutton ajsutton commented Apr 3, 2023

Description

Separate the op-e2e engine API implementation from the backend. The engine API will be used in the fault proof program as well with an oracle based backend.

The engine api implementation has moved to its own module since it will now be production code, not just part of the e2e infrastructure.

Tests

Introduced the l2_engine_api_tests.go file which provides a set of tests using a pluggable backend. This tests the engine API code better but also allows testing compatibility with each engine backend, reusing the same tests. Currently the op-e2e backend is all that calls these tests.

Metadata

TODOs

@changeset-bot
Copy link

changeset-bot bot commented Apr 3, 2023

⚠️ No Changeset found

Latest commit: 773f99b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@netlify
Copy link

netlify bot commented Apr 3, 2023

Deploy Preview for opstack-docs canceled.

Name Link
🔨 Latest commit 773f99b
🔍 Latest deploy log https://app.netlify.com/sites/opstack-docs/deploys/642cb0878baf4800084bc22a

@codecov
Copy link

codecov bot commented Apr 4, 2023

Codecov Report

Merging #5335 (36c25d3) into develop (b424c7c) will decrease coverage by 4.37%.
The diff coverage is 0.00%.

❗ Current head 36c25d3 differs from pull request most recent head 773f99b. Consider uploading reports for the commit 773f99b to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #5335      +/-   ##
===========================================
- Coverage    39.88%   35.52%   -4.37%     
===========================================
  Files          391      238     -153     
  Lines        25657    21614    -4043     
  Branches       838        0     -838     
===========================================
- Hits         10233     7678    -2555     
+ Misses       14644    13194    -1450     
+ Partials       780      742      -38     
Flag Coverage Δ
bedrock-go-tests 35.52% <0.00%> (-0.86%) ⬇️
common-ts-tests ?
contracts-bedrock-tests ?
contracts-tests ?
core-utils-tests ?
dtl-tests ?
fault-detector-tests ?
sdk-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
op-program/l2/engineapi/l2_engine_api.go 0.00% <0.00%> (ø)
...p-program/l2/engineapi/test/l2_engine_api_tests.go 0.00% <0.00%> (ø)

... and 162 files with indirect coverage changes

@ajsutton ajsutton marked this pull request as ready for review April 4, 2023 00:16
@ajsutton ajsutton requested a review from a team as a code owner April 4, 2023 00:16
Copy link
Contributor

@protolambda protolambda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice cleanup. Regarding non-L2 usage: I think it's a good idea, but also scope-creep, and we can refactor that to be more general in a separate PR.

Moves the engine API implementation to be part of op-program production code
@mergify
Copy link
Contributor

mergify bot commented Apr 4, 2023

This PR has been added to the merge queue, and will be merged soon.

@mergify
Copy link
Contributor

mergify bot commented Apr 4, 2023

This PR is next in line to be merged, and will be merged as soon as checks pass.

@OptimismBot OptimismBot merged commit d0ee681 into develop Apr 4, 2023
@OptimismBot OptimismBot deleted the aj/refactor-engine-api branch April 4, 2023 23:54
@mergify mergify bot removed the on-merge-train label Apr 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants