-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
op-program: Extract block processing logic from engine api #5350
Conversation
|
✅ Deploy Preview for opstack-docs canceled.
|
f1e835b
to
4d6c60b
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #5350 +/- ##
===========================================
- Coverage 38.67% 35.21% -3.46%
===========================================
Files 339 239 -100
Lines 25376 21836 -3540
Branches 659 0 -659
===========================================
- Hits 9814 7690 -2124
+ Misses 14818 13400 -1418
- Partials 744 746 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice refactor. One nit about RemainingBlockGas()
4d6c60b
to
08f7670
Compare
This PR has been added to the merge queue, and will be merged soon. |
Description
Make the block processing logic easier to follow and reusable by extracting it from the engine api. Besides its current usage to create blocks in the engine api it will be used to import blocks in the oracle based engine backend. Only real difference between creating and importing blocks is that when importing you commit the changes to the DB and a couple of extra verifications that the output roots all match.
Tests
Mostly covered by existing tests since this is just rearranging existing functionality but added a couple around verifying the gas limit wasn't changed too much.
Metadata