-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(specs): Rename l1Fee<x> to <x> #5401
Conversation
- `l1FeeScalar` is actually `scalar` in the code. - `l1FeeOverhead` is actually `overhead` in the code. Didn't change `exec-engine.md` because there those variable names are defined correctly. Also added update config transaction type 3 to the doc. Based on https://github.com/sherlock-audit/2023-01-optimism-judging/blob/b7921698c1c537714c5f2021aa46ce0a1935ba39/1-specs-findings/1-processed/1-true/names/213.md Closing: DEVRL-847
|
✅ Deploy Preview for opstack-docs canceled.
|
Bedrock markdown lint error is vitalk's site having a cert error again. No other issues. |
This PR has been added to the merge queue, and will be merged soon. |
I think they were named that way because it matches the L1 RPC naming that way. The code is just code, and doesn't need to 1:1 match the exact spec naming if the "l1Fee" part is clear already. |
l1FeeScalar
is actuallyscalar
in the code.l1FeeOverhead
is actuallyoverhead
in the code.Didn't change
exec-engine.md
because there those variable names are defined correctly.Also added update config transaction type 3 to the doc.
Based on https://github.com/sherlock-audit/2023-01-optimism-judging/blob/b7921698c1c537714c5f2021aa46ce0a1935ba39/1-specs-findings/1-processed/1-true/names/213.md
Closing: DEVRL-847