Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(specs): Rename l1Fee<x> to <x> #5401

Merged
merged 4 commits into from
Apr 10, 2023

Conversation

qbzzt
Copy link
Contributor

@qbzzt qbzzt commented Apr 10, 2023

  • l1FeeScalar is actually scalar in the code.
  • l1FeeOverhead is actually overhead in the code.

Didn't change exec-engine.md because there those variable names are defined correctly.

Also added update config transaction type 3 to the doc.

Based on https://github.com/sherlock-audit/2023-01-optimism-judging/blob/b7921698c1c537714c5f2021aa46ce0a1935ba39/1-specs-findings/1-processed/1-true/names/213.md

Closing: DEVRL-847

- `l1FeeScalar` is actually `scalar` in the code.
- `l1FeeOverhead` is actually `overhead` in the code.

Didn't change `exec-engine.md` because there those variable names are defined correctly.

Also added update config transaction type 3 to the doc.

Based on https://github.com/sherlock-audit/2023-01-optimism-judging/blob/b7921698c1c537714c5f2021aa46ce0a1935ba39/1-specs-findings/1-processed/1-true/names/213.md

Closing: DEVRL-847
@qbzzt qbzzt requested review from a team as code owners April 10, 2023 14:21
@changeset-bot
Copy link

changeset-bot bot commented Apr 10, 2023

⚠️ No Changeset found

Latest commit: 0f8a7e8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@netlify
Copy link

netlify bot commented Apr 10, 2023

Deploy Preview for opstack-docs canceled.

Name Link
🔨 Latest commit 0f8a7e8
🔍 Latest deploy log https://app.netlify.com/sites/opstack-docs/deploys/6434240d272a7e0008f8cdc8

@trianglesphere
Copy link
Contributor

Bedrock markdown lint error is vitalk's site having a cert error again. No other issues.

@mergify
Copy link
Contributor

mergify bot commented Apr 10, 2023

This PR has been added to the merge queue, and will be merged soon.

@trianglesphere trianglesphere merged commit 1afd173 into develop Apr 10, 2023
@trianglesphere trianglesphere deleted the qbzzt/230310-spec-withdrawal branch April 10, 2023 17:19
@mergify mergify bot removed the on-merge-train label Apr 10, 2023
@protolambda
Copy link
Contributor

I think they were named that way because it matches the L1 RPC naming that way. The code is just code, and doesn't need to 1:1 match the exact spec naming if the "l1Fee" part is clear already.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants