Binary testnet holocene timestamp added #749
Conversation
| @@ -8,8 +8,9 @@ batch_inbox_addr = "0xFf00000000000000000000000000000000042069" | |||
| canyon_time = 0 # Thu 1 Jan 1970 00:00:00 UTC | |||
| delta_time = 0 # Thu 1 Jan 1970 00:00:00 UTC | |||
| ecotone_time = 0 # Thu 1 Jan 1970 00:00:00 UTC | |||
| fjord_time = 1723204838 #Saturday June 8 2024 10:47:18 AM UTC | |||
There was a problem hiding this comment.
Strange that these timestamp comments incorrect before -- @bitwiseguy do we know why?
There was a problem hiding this comment.
The old ones look like they were created manually, not with date -u -r.
superchain/configs/sepolia/tbn.toml
Outdated
| granite_time = 1723545055 #Monday June 12 2024 1:57:35 PM UTC | ||
| fjord_time = 1723204838 # Fri Aug 09 2024 12:00:38 UTC | ||
| granite_time = 1723545055 # Tue Aug 13 2024 10:30:55 UTC | ||
| holocene_time = 1732633200 # Tue Nov 26 15:00:00 UTC 2024 |
There was a problem hiding this comment.
Do you intend for this chain to receive all future hardforks in sync with the rest of the superchain? If so, I recommend following these instructions https://github.com/ethereum-optimism/superchain-registry/?tab=readme-ov-file#hardfork-activations
| fjord_time = 1723204838 # Fri Aug 09 2024 12:00:38 UTC | ||
| granite_time = 1723545055 # Tue Aug 13 2024 10:30:55 UTC |
There was a problem hiding this comment.
verified that the timestamps in the corrected comments are ✅
superchain/configs/sepolia/tbn.toml
Outdated
| granite_time = 1723545055 #Monday June 12 2024 1:57:35 PM UTC | ||
| fjord_time = 1723204838 # Fri Aug 09 2024 12:00:38 UTC | ||
| granite_time = 1723545055 # Tue Aug 13 2024 10:30:55 UTC | ||
| holocene_time = 1732633200 # Tue Nov 26 15:00:00 UTC 2024 |
There was a problem hiding this comment.
Note that the Sepolia activation has already passed over a week ago. Did you locally set this with an override on all your nodes?
If that's intentional, you probably want to receive all future hardfork from Holocene onwards, so better just set the superchain_time.
| holocene_time = 1732633200 # Tue Nov 26 15:00:00 UTC 2024 | |
| superchain_time = 1732633200 # Holocene - Tue Nov 26 15:00:00 UTC 2024 |
There was a problem hiding this comment.
This is a Custom Gas token Chain do you suggest that we can use superchain_time and it will not cause any issue ?
There was a problem hiding this comment.
Setting superchain_time simply means that you inherit the activation times that are set for the superchain automatically. That also works for CGT chains.
There was a problem hiding this comment.
But again, the Sepolia activation has already passed. Do you intentionally retroactively set the Sepolia Holocene activation time because you locally activated last week with overrides?
There was a problem hiding this comment.
yes i locally activated Holocene last week using overrides.
Co-authored-by: Sebastian Stammler <stammler.s@gmail.com>
Adding a New Chain
This PR adds [Chain Name Here] to the registry.
Checklist
just validate <chain-id>locally to ensure all local validation checks pass.just codegento ensure that the chainlist and other generated files are up-to-date and include my chain.