Binary testnet holocene timestamp added #749
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -8,8 +8,9 @@ batch_inbox_addr = "0xFf00000000000000000000000000000000042069" | |||||
| canyon_time = 0 # Thu 1 Jan 1970 00:00:00 UTC | ||||||
| delta_time = 0 # Thu 1 Jan 1970 00:00:00 UTC | ||||||
| ecotone_time = 0 # Thu 1 Jan 1970 00:00:00 UTC | ||||||
| fjord_time = 1723204838 # Fri Aug 09 2024 12:00:38 UTC | ||||||
| granite_time = 1723545055 # Tue Aug 13 2024 10:30:55 UTC | ||||||
|
Comment on lines
+11
to
+12
There was a problem hiding this comment. verified that the timestamps in the corrected comments are ✅ |
||||||
| holocene_time = 1732633200 # Tue Nov 26 15:00:00 UTC 2024 | ||||||
|
There was a problem hiding this comment. Do you intend for this chain to receive all future hardforks in sync with the rest of the superchain? If so, I recommend following these instructions https://github.com/ethereum-optimism/superchain-registry/?tab=readme-ov-file#hardfork-activations There was a problem hiding this comment. Note that the Sepolia activation has already passed over a week ago. Did you locally set this with an override on all your nodes? If that's intentional, you probably want to receive all future hardfork from Holocene onwards, so better just set the
Suggested change
There was a problem hiding this comment. This is a Custom Gas token Chain do you suggest that we can use superchain_time and it will not cause any issue ? There was a problem hiding this comment. Setting There was a problem hiding this comment. But again, the Sepolia activation has already passed. Do you intentionally retroactively set the Sepolia Holocene activation time because you locally activated last week with overrides? There was a problem hiding this comment. yes i locally activated Holocene last week using overrides. |
||||||
| block_time = 2 | ||||||
| seq_window_size = 3600 | ||||||
| max_sequencer_drift = 600 | ||||||
|
|
||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Strange that these timestamp comments incorrect before -- @bitwiseguy do we know why?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The old ones look like they were created manually, not with
date -u -r.