move 2612 to Review #4653
Merged
move 2612 to Review #4653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All tests passed; auto-merging...(pass) eip-2612.md
|
lightclient
requested changes
Jan 11, 2022
|
@lightclient I've pushed a commit that implements your suggestions |
MrChico
approved these changes
Jan 24, 2022
|
Thanks for picking this up @wschwab , this looks good to me! |
axic
reviewed
Jan 24, 2022
axic
reviewed
Jan 24, 2022
axic
reviewed
Jan 24, 2022
lightclient
approved these changes
Feb 8, 2022
PowerStream3604
pushed a commit
to PowerStream3604/EIPs
that referenced
this pull request
May 19, 2022
* move 2612 to Review * implemented suggestions * implemented axic suggestions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves EIP-2612 to Review. EIP-2612 enjoys widespread adoption, and imho should be moved forward in the EIP process. I have spoked with the EIP's author, @MrChico , and has told me that he is content with the specification as-is, and would be interested and it seeing it move forward.