Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move EIP 3668 to Final #4746

Merged
merged 1 commit into from
Feb 8, 2022
Merged

Move EIP 3668 to Final #4746

merged 1 commit into from
Feb 8, 2022

Conversation

Arachnid
Copy link
Contributor

@Arachnid Arachnid commented Feb 2, 2022

The following issues were raised during the last call process and addressed:

  • Optional (for gateways) support for POST requests because of the 2k limit on URL length.
  • Additional notes in the security section about fingerprinting risks and how to mitigate them.
  • Additional notes on how CCIP read aware contracts should handle nested calls.

With these addressed I do not believe there is any further barrier to moving this EIP to Final status.

@eth-bot
Copy link
Collaborator

eth-bot commented Feb 2, 2022 •
edited
Loading

All tests passed; auto-merging...

(pass) eip-3668.md

classification
updateEIP
  • passed!

lightclient
lightclient approved these changes Feb 8, 2022
View reviewed changes
Copy link
Member

@lightclient lightclient left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kodiakhq kodiakhq bot merged commit 93d3ebb into ethereum:master Feb 8, 2022
@Arachnid Arachnid deleted the 3668-final branch February 8, 2022 20:12
@poojaranjan poojaranjan mentioned this pull request Feb 9, 2022
Closed
PowerStream3604 pushed a commit to PowerStream3604/EIPs that referenced this pull request May 19, 2022
@Arachnid @PowerStream3604
Move EIP 3668 to Final (ethereum#4746)
a937625
@dillchen dillchen mentioned this pull request Aug 10, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lightclient lightclient lightclient approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Arachnid @eth-bot @lightclient