Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add IDE filenames to .gitignore #50

Merged
merged 1 commit into from
Jan 19, 2021

Conversation

tmckenzie51
Copy link
Contributor

What was wrong?

IDE files such as .idea and pip-wheel-metadata were not included in .gitignore

How was it fixed?

.idea* and pip-wheel-metadata were added to the .gitignore file

@tmckenzie51
Copy link
Contributor Author

@pipermerriam Can you review this for me ?

@carver carver merged commit 3a0fcae into ethereum:master Jan 19, 2021
@carver
Copy link
Collaborator

carver commented Jan 19, 2021

@tmckenzie51 was there anything outside of .idea/ or .idea_modules/ that needs to be skipped? I was wondering if we could ignore something a little smaller than .idea*.

@tmckenzie51
Copy link
Contributor Author

tmckenzie51 commented Feb 23, 2021

@carver I believe there are 4 different .idea* files that need to be skipped. I could list the 4 of them in .gitignore instead if that is preferred.

@carver
Copy link
Collaborator

carver commented Feb 23, 2021

Yeah, sure, that would be great. Would you check it against the link in the comment of the .gitignore? Also, it looks like I added a duplicate idea_modules/ by accident, so feel free to delete that while you're there. Thanks!

@tmckenzie51
Copy link
Contributor Author

@carver Okay. I just did that here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants