-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update .gitignore based on IntelliJ docs #57
Conversation
updated based on IntelliJ documentation
59f2412
to
ab0f37d
Compare
@carver I've updated the |
.gitignore
Outdated
|
||
|
||
## Uncomment if using auto-import. | ||
# .idea/py_ecc.iml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line looks specific to one project, which seems wrong for going into a template.
Also, I take it that you do actually want to commit some files in .idea/
and that's why the nitpicking ignore file here? It makes me sad that it adds so much clutter :/ . Also, I'm not sure we want new contributors accidentally adding (any of) their .idea files by default across all projects based on this template.
I'll think about it a bit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops, thanks for catching that. I've generalized the file name as idea/*.iml
. I also uncommented this section, instead saying "Comment out if not using auto-import" to prevent new contributors from accidentally adding their idea/*.im
l files. It is still a bit of clutter. I can remove the new comment from the file if you think it isn't necessary.
Can you give an example of an |
@carver According to the IntelliJ docs, "All the files under the .idea directory in the project root except the workspace.xml, usage.statistics.xml, and tasks.xml files and the shelf directory which store user-specific settings" should be shared. In my PR in the py_ecc library two |
Closing as stale. Please file a new issue if needed. |
updated based on IntelliJ documentation
What was wrong?
.idea/*
listed in.gitignore
encompassed.idea
files that we want to share rather than ignore.Related to : #50 (comment)
How was it fixed?
Specific
.idea
files were listed in .gitignore based on IntelliJ documentation here.Cute Animal Picture