Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Check for unexpected EOF prefix in tests #809

Merged
merged 1 commit into from
Feb 12, 2024

Conversation

chfast
Copy link
Member

@chfast chfast commented Feb 8, 2024

In the validate_state() also check for unexpected code with EOF prefix before EOF is enabled. The EIP-3541 prevents such code to be deployed.

Copy link

codecov bot commented Feb 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e4bcf7c) 97.79% compared to head (a0ff4f9) 97.95%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #809      +/-   ##
==========================================
+ Coverage   97.79%   97.95%   +0.16%     
==========================================
  Files         110      110              
  Lines       10822    10827       +5     
==========================================
+ Hits        10583    10606      +23     
+ Misses        239      221      -18     
Flag Coverage Δ
blockchaintests 59.88% <ø> (ø)
statetests 62.16% <0.00%> (?)
statetests-silkpre 25.53% <0.00%> (-0.02%) ⬇️
unittests 95.96% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
test/statetest/statetest_loader.cpp 96.49% <100.00%> (+0.01%) ⬆️
test/unittests/statetest_loader_test.cpp 100.00% <100.00%> (ø)

... and 5 files with indirect coverage changes

In the `validate_state()` also check for unexpected code with EOF prefix
before EOF is enabled. The EIP-3541 prevents such code to be deployed.
@chfast chfast force-pushed the test/validate_state_eof branch from 8e94640 to a0ff4f9 Compare February 8, 2024 15:00
@chfast chfast merged commit 75eb1f2 into master Feb 12, 2024
25 checks passed
@chfast chfast deleted the test/validate_state_eof branch February 12, 2024 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants