fix(pytest): actually check the fork before issuing a fork mismatch warning for yul compilation #429
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗒️ Description
This PR fixes an error introduced in #418:
src/pytest_plugins/test_filler/test_filler.py
always issued a warning for an incorrect fork, regardless of whetherget_closest_fork_with_solc_support()
returned the requried fork, or not. For example,with a solc that supports Shanghai incorrectly warns:
🔗 Related Issues
None.
✅ Checklist
mkdocs serve
locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.