-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bug(pytest, forks): fix yul_test
marker and improve solc --evm-version
param handling
#418
Merged
danceratopz
merged 14 commits into
ethereum:main
from
danceratopz:fix/pytest/fix-yul_test_marker__improve_compile_yul_with_marker
Feb 1, 2024
Merged
bug(pytest, forks): fix yul_test
marker and improve solc --evm-version
param handling
#418
danceratopz
merged 14 commits into
ethereum:main
from
danceratopz:fix/pytest/fix-yul_test_marker__improve_compile_yul_with_marker
Feb 1, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danceratopz
added
type:bug
Something isn't working
scope:forks
Scope: ethereum_test_forks package
scope:pytest
Scope: Pytest plugins
labels
Jan 30, 2024
danceratopz
commented
Jan 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few comments.
6 tasks
danceratopz
requested review from
marioevz
and removed request for
marioevz and
spencer-tb
January 31, 2024 15:36
danceratopz
commented
Jan 31, 2024
spencer-tb
approved these changes
Jan 31, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I really like the approach with solc_min_version()
spencer-tb
reviewed
Jan 31, 2024
…ile_yul_with_marker
spencer-tb
changed the title
fix (pytest, forks): fix
bug(pytest, forks): fix Feb 1, 2024
yul_test
marker and improve solc --evm-version
param handlingyul_test
marker and improve solc --evm-version
param handling
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
scope:forks
Scope: ethereum_test_forks package
scope:pytest
Scope: Pytest plugins
type:bug
Something isn't working
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗒️ Description
fill -m yul_test
which failed to filter tests that were (dynamically) marked as a yul test.--evm-version
.--evm-version
if the current fork is not supported.fill
early in case of raising an incompatible solc. Previously this would return an error for every collected test:Opened as draft, remaining to do:
ethereum_test_forks.helpers
.Won't add pytest framework tests for
pytest_plugins.test_filler
. Would be nice, but we currently don't currently manage available solc versions, so results are undefined.🔗 Related Issues
None.
✅ Checklist
mkdocs serve
locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.