new(tests): EOF - EIP-7620: tests for msg.depth and static flag #732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marioevz
reviewed
Aug 8, 2024
tests/prague/eip7692_eof_v1/eip7620_eof_create/test_eofcreate_failures.py
Outdated
Show resolved
Hide resolved
tests/prague/eip7692_eof_v1/eip7620_eof_create/test_eofcreate_failures.py
Outdated
Show resolved
Hide resolved
marioevz
approved these changes
Aug 10, 2024
pdobacz
force-pushed
the
eofcreate-tests
branch
from
02393be to
e2d3238
Compare
Done, I've also noticed I should have simplified the memory layout, and then documented it a bit more (I agree it was very hard to follow) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mainly inspired by ipsilon/eof#138 and evmone state_transition tests. Following the conventions used in #730, in particular the test
test_eof_eofcreate_msg_depthis an extension of thetest_eof_calls_msg_depth, just even more complex and magic. I'm not sure if this isn't too much, WDYT? It would however be good to have this (exotic) condition covered (and we decided we do want thismsg.depthrule applied for various reasons).