Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downgrade EIP-7069 and 7620 testing readiness #138

Merged
merged 1 commit into from
Jul 1, 2024
Merged

Downgrade EIP-7069 and 7620 testing readiness #138

merged 1 commit into from
Jul 1, 2024

Conversation

pdobacz
Copy link
Member

@pdobacz pdobacz commented Jun 27, 2024

I've found gaps in coverage of evmone produced by EEST and ethereum/tests, so I think we should downgrade these two and work on filling in the gaps.

Rough notes on what I've found to be missing, correct me if I missed sth:

  1. RETURNDATACOPY copy cost oog https://app.codecov.io/gh/ethereum/evmone/blob/master/lib%2Fevmone%2Finstructions.hpp?flags%5B0%5D=eof_execution_spec_tests&flags%5B1%5D=ethereum_tests&flags%5B2%5D=execution_spec_tests&flags%5B3%5D=ethereum_tests_silkpre
  2. DATACOPY copy cost oog and mem expansion cost oog https://app.codecov.io/gh/ethereum/evmone/blob/master/lib%2Fevmone%2Finstructions.hpp?flags%5B0%5D=eof_execution_spec_tests&flags%5B1%5D=ethereum_tests&flags%5B2%5D=execution_spec_tests&flags%5B3%5D=ethereum_tests_silkpre
  3. CALLF runtime stack overflow https://app.codecov.io/gh/ethereum/evmone/blob/master/lib%2Fevmone%2Finstructions.hpp?flags%5B0%5D=eof_execution_spec_tests&flags%5B1%5D=ethereum_tests&flags%5B2%5D=execution_spec_tests&flags%5B3%5D=ethereum_tests_silkpre
  4. JUMPF runtime stack overflow https://app.codecov.io/gh/ethereum/evmone/blob/master/lib%2Fevmone%2Finstructions.hpp?flags%5B0%5D=eof_execution_spec_tests&flags%5B1%5D=ethereum_tests&flags%5B2%5D=execution_spec_tests&flags%5B3%5D=ethereum_tests_silkpre
  5. instruction_calls - many areas missing https://app.codecov.io/gh/ethereum/evmone/blob/master/lib%2Fevmone%2Finstructions_calls.cpp?flags%5B0%5D=eof_execution_spec_tests&flags%5B1%5D=ethereum_tests&flags%5B2%5D=execution_spec_tests&flags%5B3%5D=ethereum_tests_silkpre
    • EXT*CALL cold access oog
    • EXT*CALL mem expansion oog
    • EXT*CALL input
    • EXT*CALL static mode violation on value transfer
    • EXT*CALL account creation on value transfer
    • EXT*CALL oog on account creatoin on value transfer
    • EXT*CALL "light failure" scenarios:
      • msg.depth
      • not enough balance
      • MIN_CALLEE_GAS violation
    • EXT*CALL callee reverts
    • EOFCREATE - static mode violation
    • EOFCREATE - mem expansion oog
    • EOFCREATE - msg.depth light failure

@pdobacz pdobacz self-assigned this Jun 27, 2024
@pdobacz pdobacz requested a review from chfast June 27, 2024 11:22
Copy link
Member

@chfast chfast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think should only consider execution_spec_tests in the analysis.

@pdobacz
Copy link
Member Author

pdobacz commented Jul 22, 2024

CALLF / JUMPF points covered in ethereum/execution-spec-tests#678 and ethereum/execution-spec-tests#690

Given the two other PRs which GH linked for us above, only the EXT*CALL point is remaining

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants