Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new(tests): EOF - EIP-7069 - expand EXT*CALL gas testing #771

Merged
merged 6 commits into from
Sep 11, 2024

Conversation

pdobacz
Copy link
Collaborator

@pdobacz pdobacz commented Aug 28, 2024

🗒️ Description

Expand the gas testing mechanism from test_gas.py to handle also oog conditions. Then leverage it to test several new conditions for EXT*CALL (mem expansion and account creation). CC @shemnon

🔗 Related Issues

Cases taken from coverage gaps report in ipsilon/eof#138

✅ Checklist

  • All: Set appropriate labels for the changes.
  • All: Considered squashing commits to improve commit history.
  • All: Added an entry to CHANGELOG.md.
  • All: Considered updating the online docs in the ./docs/ directory.
  • Tests: All converted JSON/YML tests from ethereum/tests have been added to converted-ethereum-tests.txt.
  • Tests: A PR with removal of converted JSON/YML tests from ethereum/tests have been opened.
  • Tests: Included the type and version of evm t8n tool used to locally execute test cases: e.g., ref with commit hash or geth 1.13.1-stable-3f40e65.
  • Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.

Copy link
Member

@marioevz marioevz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really good overall, just a couple of minor comments. Thanks!

tests/prague/eip7692_eof_v1/eip7069_extcall/test_gas.py Outdated Show resolved Hide resolved
tests/prague/eip7692_eof_v1/tracker.md Outdated Show resolved Hide resolved
tests/prague/eip7692_eof_v1/eip7069_extcall/test_gas.py Outdated Show resolved Hide resolved
tests/prague/eip7692_eof_v1/eip7069_extcall/test_gas.py Outdated Show resolved Hide resolved
Copy link
Member

@marioevz marioevz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pdobacz pdobacz changed the title new(tests): EOF - EIP-7069 - expand ext*call gas testing new(tests): EOF - EIP-7069 - expand EXT*CALL gas testing Sep 9, 2024
@pdobacz pdobacz requested a review from marioevz September 10, 2024 07:49
Copy link
Member

@danceratopz danceratopz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but did the test ids get mixed up?

tests/prague/eip7692_eof_v1/eip7069_extcall/test_gas.py Outdated Show resolved Hide resolved
tests/prague/eip7692_eof_v1/eip7069_extcall/test_gas.py Outdated Show resolved Hide resolved
tests/prague/eip7692_eof_v1/eip7069_extcall/test_gas.py Outdated Show resolved Hide resolved
tests/prague/eip7692_eof_v1/eip7069_extcall/test_gas.py Outdated Show resolved Hide resolved
tests/prague/eip7692_eof_v1/eip7069_extcall/test_gas.py Outdated Show resolved Hide resolved
Co-authored-by: danceratopz <danceratopz@gmail.com>
@danceratopz danceratopz added scope:tests Scope: Test cases type:feat type: Feature labels Sep 11, 2024
Copy link
Member

@danceratopz danceratopz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM!

@danceratopz danceratopz merged commit 061e41c into ethereum:main Sep 11, 2024
4 checks passed
@danceratopz danceratopz deleted the extcall-oog branch September 11, 2024 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope:tests Scope: Test cases type:feat type: Feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants