Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support underscores in numeric literals #149

Closed
cburgdorf opened this issue Dec 7, 2020 · 7 comments · Fixed by #701
Closed

Support underscores in numeric literals #149

cburgdorf opened this issue Dec 7, 2020 · 7 comments · Fixed by #701

Comments

@cburgdorf
Copy link
Collaborator

Abstract

We should support underscores _ in numeric literals so that 1000000000000000000 can be written in the more readable form of 1_000_000_000_000_000_000.

Motivation

Fe is intended to be used in smart contract development and variables and constants holding large numerals is a very well expected normal use case. Especially since many variables are going to represent Wei and e.g. 1_000_000_000_000_000_000 Wei represent 1 Ether.

@plv
Copy link

plv commented May 18, 2021

Hi, does this still need doing? Happy to take it on.

@cburgdorf
Copy link
Collaborator Author

@plv yes, feel free to take it!

@voith
Copy link

voith commented Sep 23, 2021

@plv are you still working on this? If not can I take this up?

@plv
Copy link

plv commented Oct 5, 2021

@voith Sorry for the late response -- I never got around to this. Feel free to take it :)

@Jake-Steck
Copy link

@plv Hi, does this still need help? I am here if so.

@cburgdorf
Copy link
Collaborator Author

@Jake-Steck it doesn't seem that anyone is currently actively working on it so feel free to make it yours :)

@voith
Copy link

voith commented Nov 9, 2021

@Jake-Steck I never got started on this. So feel free to take it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants