feat/support underscore in numberic

[vuvoth]

Proposed Changes

Support underscore for readable in numberic type.
Close #149

Implementation

• Add regex rule to parser/lexer/token.rs

Please review my PR! Thanks!

To-Do

• OPTIONAL: Update Spec if applicable

• Add entry to the release notes (may forgo for trivial changes)

• Clean up commit history

[codecov-commenter]

Codecov Report

Merging #701 (002f667) into master (d580097) will decrease coverage by 0.03%.
The diff coverage is 68.75%.

❗ Current head 002f667 differs from pull request most recent head c70184b. Consider uploading reports for the commit c70184b to get more accurate results

@@            Coverage Diff             @@
##           master     #701      +/-   ##
==========================================
- Coverage   82.03%   81.99%   -0.04%     
==========================================
  Files         125      125              
  Lines       10891    10937      +46     
==========================================
+ Hits         8934     8968      +34     
- Misses       1957     1969      +12     

Impacted Files	Coverage Δ
crates/parser/src/ast.rs	87.53% <0.00%> (-1.01%)	⬇️
crates/parser/src/lexer/token.rs	17.97% <ø> (ø)
crates/parser/src/grammar/functions.rs	89.27% <72.50%> (-1.25%)	⬇️
crates/lowering/src/mappers/functions.rs	99.42% <100.00%> (+<0.01%)	⬆️
crates/lowering/src/mappers/module.rs	85.54% <100.00%> (+0.17%)	⬆️
crates/yulgen/src/runtime/abi_dispatcher.rs	100.00% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d580097...c70184b. Read the comment docs.

[cburgdorf]

Great!

Could you also add another test case here to prove that something like 100_000_ or _1_0 is still rejected.

fe/crates/parser/tests/cases/errors.rs

Line 84 in c6edbe8

test_parse_err! { expr_dotted_number, expressions::parse_expr, "3.14" }

Lastly, can you add a file newsfragments/149.feature.md with the contents being something like

Support for underscores in numbers to improve readability e.g. `100_000`

This is to ensure the feature will be included in the upcoming release notes.

[vuvoth]

Could you also add another test case here to prove that something like 100_000_ or _1_0 is still rejected.

I have problem is when I write "fail tests" case error but snap file body is empty. How I can handle it?

Lastly, can you add a file newsfragments/149.feature.md with the contents being something like

I don't know format of the newfragments files. Have any source for me to reference ?

[sbillig]

I have problem is when I write "fail tests" case error but snap file body is empty. How I can handle it?

I guess you probably figured this out, but the snapshot testing stuff uses insta. You can just add a new test and run it. The test will initially fail, because the new snapshot won't match the "current" (non-existent) snapshot. To accept the snapshot, it's easiest to use cargo insta review (which requires a cargo install cargo-insta first).

I don't know format of the newfragments files. Have any source for me to reference ?

Usually there are some examples in there, but they're removed on every release and added to the changelog. What you have is good, just drop the leading # and add a trailing newline.

[cburgdorf]

Thank you very much for your work @vuvoth
Merged! 🎉