Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extern and intrinsics #813

Draft
wants to merge 24 commits into
base: master
Choose a base branch
from
Draft

Extern and intrinsics #813

wants to merge 24 commits into from

Conversation

Y-Nak
Copy link
Member

@Y-Nak Y-Nak commented Nov 15, 2022

What was wrong?

How was it fixed?

To-Do

  • OPTIONAL: Update Spec if applicable

  • Add entry to the release notes (may forgo for trivial changes)

  • Clean up commit history

@Y-Nak Y-Nak force-pushed the extern-and-intrinsics branch 3 times, most recently from 3df32a2 to 53b3926 Compare November 15, 2022 21:48
@cburgdorf
Copy link
Collaborator

I understood your comment here that you were ok with attributes that don't need brackets. Did I misinterpret or have you changed your mind about that?

@Y-Nak
Copy link
Member Author

Y-Nak commented Nov 16, 2022

I just forgot sean's comment and thought brackets are necessary to allow NAME = EXPR in attributes. But as Sean pointed out in the comment, it should be much better for attributes to have the same syntax as a function call like #target(evm) or #cfg(target: evm, abi: nu). I'll remove the commit and make it back to the original. Thanks for pointing that out!

@Y-Nak Y-Nak force-pushed the extern-and-intrinsics branch 7 times, most recently from 839cea9 to 7a5f2be Compare November 28, 2022 23:09
@Y-Nak
Allow functions to have attributes
5e07388
@Y-Nak
Add parser for extern block
999779d
@Y-Nak
Remove ; following trait fn declarations
c9777a1
@Y-Nak
Fix trait's Display implementation
fa854e7
@Y-Nak
Allow calling a function defined outside of ingot
04be56d
@Y-Nak
Add TypeParam type to mir types
2114017
@Y-Nak
Remove monomorphization phase from mir lowering
623c5d8
@Y-Nak
Allow printing function signature with type parameters
e877908
@Y-Nak
Add emit=mir option
a417df8
@Y-Nak
Add a missing self type in a trait method declaration
921d5cc
@Y-Nak
Add query to enumerate all functions in a module
2029ac4
@Y-Nak
Add name field to mir::FunctionSig
3a98ace
@Y-Nak
Add utility methods to modify mir function body in place
a06037e
@Y-Nak
Enable to lookup a function body by its signature even when its paren…
ee6c237 
…t is a module
@Y-Nak
Define a codegen unit structure
6bb4d4d
@Y-Nak
Implement function monomorphization in the CGUs generation phase
5fb3bd1
@Y-Nak Y-Nak force-pushed the extern-and-intrinsics branch 2 times, most recently from 3bdbb21 to a239f2a Compare December 10, 2022 01:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Y-Nak @cburgdorf