Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Language server concurrency and functionality upgrades #979

Open
wants to merge 66 commits into
base: fe-v2
Choose a base branch
from
Open

Language server concurrency and functionality upgrades #979

wants to merge 66 commits into from

Commits on Feb 29, 2024

  1. Start moving LSP server to tower

    @micahscopes
    micahscopes committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    e5c5d09 View commit details
    Browse the repository at this point in the history

  2. tower-lsp logging

    @micahscopes
    micahscopes committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    1e30c00 View commit details
    Browse the repository at this point in the history

  3. language server clippy/fmt

    @micahscopes
    micahscopes committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    9589ef1 View commit details
    Browse the repository at this point in the history

  4. language server tower refactor minor cleanup

    @micahscopes
    micahscopes committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    936986f View commit details
    Browse the repository at this point in the history

  5. language server tower-lsp refactor cleanup; WIP

    @micahscopes
    micahscopes committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    dbda904 View commit details
    Browse the repository at this point in the history

  6. language server clippy/fmt

    @micahscopes
    micahscopes committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    f28784e View commit details
    Browse the repository at this point in the history

  7. Language server prevent deadlocks

    @micahscopes
    micahscopes committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    54a1c59 View commit details
    Browse the repository at this point in the history

  8. language server: clarify async shared state design

    @micahscopes
    micahscopes committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    41e206a View commit details
    Browse the repository at this point in the history

  9. language server code cleanup

    @micahscopes
    micahscopes committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    f3dc655 View commit details
    Browse the repository at this point in the history

  10. workspace file removal improvement

    @micahscopes
    micahscopes committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    fcdd0d9 View commit details
    Browse the repository at this point in the history

  11. generate LSP event channels automatically

    @micahscopes
    micahscopes committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    7a67675 View commit details
    Browse the repository at this point in the history

Commits on Mar 1, 2024

  1. attempt at oneshot responses

    @micahscopes
    micahscopes committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    f56052a View commit details
    Browse the repository at this point in the history

  2. stream handlers for LSP functionality

    @micahscopes
    micahscopes committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    843ed9a View commit details
    Browse the repository at this point in the history

  3. formatting and cleanup

    @micahscopes
    micahscopes committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    63fd1cd View commit details
    Browse the repository at this point in the history

Commits on Mar 28, 2024

  1. language server concurrency progress

    @micahscopes
    micahscopes committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    763a956 View commit details
    Browse the repository at this point in the history

  2. no deadlocks

    @micahscopes
    micahscopes committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    07eaa42 View commit details
    Browse the repository at this point in the history

  3. no need for state locks!

    @micahscopes
    micahscopes committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    71d48a7 View commit details
    Browse the repository at this point in the history

  4. goto, hover; prevent panic in LSP channel response

    @micahscopes
    micahscopes committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    a9e69a7 View commit details
    Browse the repository at this point in the history

  5. formatting

    @micahscopes
    micahscopes committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    bbef3a3 View commit details
    Browse the repository at this point in the history

  6. clippy

    @micahscopes
    micahscopes committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    c9f9984 View commit details
    Browse the repository at this point in the history

  7. pull some LSP channel code out of proc macro for better debugging

    @micahscopes
    micahscopes committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    a3079db View commit details
    Browse the repository at this point in the history

  8. avoid unnecessary manual spawns

    @micahscopes
    micahscopes committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    e1e9efb View commit details
    Browse the repository at this point in the history

  9. separate tokio runtime for stream handling

    @micahscopes
    micahscopes committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    45ef9f3 View commit details
    Browse the repository at this point in the history

  10. generated struct name customization

    @micahscopes
    micahscopes committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    c37db92 View commit details
    Browse the repository at this point in the history

  11. lsp channel responder cleanup

    @micahscopes
    micahscopes committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    ff33a22 View commit details
    Browse the repository at this point in the history

  12. cleanup; remove unneeded lock

    @micahscopes
    micahscopes committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    d9c35b6 View commit details
    Browse the repository at this point in the history

  13. exclude language-server from wasm tests

    @micahscopes
    micahscopes committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    8e7d64c View commit details
    Browse the repository at this point in the history

  14. formatting

    @micahscopes
    micahscopes committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    29b2197 View commit details
    Browse the repository at this point in the history

  15. separate workspace file methods by mutability

    @micahscopes
    micahscopes committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    4b109a5 View commit details
    Browse the repository at this point in the history

  16. language server get rid of unnecessary mutable references

    @micahscopes
    micahscopes committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    e2dd385 View commit details
    Browse the repository at this point in the history

  17. language server: even Arc/RwLock wrapped salsadb is not Send/Sync

    @micahscopes
    micahscopes committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    6356ba4 View commit details
    Browse the repository at this point in the history

  18. language server: reflock issues are due to salsa!

    @micahscopes
    micahscopes committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    dad57c1 View commit details
    Browse the repository at this point in the history

  19. Revert "language server: reflock issues are due to salsa!" 

    This reverts commit 76daadb.
    @micahscopes
    micahscopes committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    693f67b View commit details
    Browse the repository at this point in the history

  20. Revert "language server: even Arc/RwLock wrapped salsadb is not Send/… 

    …Sync"

This reverts commit 4ef6a17.
    @micahscopes
    micahscopes committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    6a2cc6f View commit details
    Browse the repository at this point in the history

  21. language server snapshot mechanism

    @micahscopes
    micahscopes committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    64e24f1 View commit details
    Browse the repository at this point in the history

  22. multithreaded diagnostics

    @micahscopes
    micahscopes committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    9c46292 View commit details
    Browse the repository at this point in the history

  23. language server: use mpsc instead of broadcast channels

    @micahscopes
    micahscopes committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    93a2c1b View commit details
    Browse the repository at this point in the history

  24. language server: proc macro cleanup

    @micahscopes
    micahscopes committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    d530bdd View commit details
    Browse the repository at this point in the history

  25. language server buffer/release mechanism

    @micahscopes
    micahscopes committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    bdbf124 View commit details
    Browse the repository at this point in the history

  26. buffer/release stream

    @micahscopes
    micahscopes committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    e5c1a4b View commit details
    Browse the repository at this point in the history

  27. higher order stream buffer

    @micahscopes
    micahscopes committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    cb492ff View commit details
    Browse the repository at this point in the history

  28. language server tweaks

    @micahscopes
    micahscopes committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    7ae47ad View commit details
    Browse the repository at this point in the history

  29. use unbounded channels

    @micahscopes
    micahscopes committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    dd983aa View commit details
    Browse the repository at this point in the history

  30. language server tower-lsp rewrite cleanup

    @micahscopes
    micahscopes committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    55dbc4d View commit details
    Browse the repository at this point in the history

  31. workspace cleanup; fix panic

    @micahscopes
    micahscopes committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    e746872 View commit details
    Browse the repository at this point in the history

  32. formatting

    @micahscopes
    micahscopes committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    b464e12 View commit details
    Browse the repository at this point in the history

  33. remove unused stream modifier; rustfmt

    @micahscopes
    micahscopes committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    ea9351f View commit details
    Browse the repository at this point in the history

  34. language server: load fe std lib in language server 

    TODO: figure out how to load the standard lib into the salsa db
and how to include it in diagnostics
    @micahscopes
    micahscopes committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    a844f57 View commit details
    Browse the repository at this point in the history

  35. batched ingot-wide diagnostics; cleanup

    @micahscopes
    micahscopes committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    ac213e6 View commit details
    Browse the repository at this point in the history

  36. test files for language server hover docs

    @micahscopes
    micahscopes committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    e56f9a4 View commit details
    Browse the repository at this point in the history

  37. language server: use tracing and tracing-subscriber

    @micahscopes
    micahscopes committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    fcd2264 View commit details
    Browse the repository at this point in the history

  38. temporarily suppress dead code warning

    @micahscopes
    micahscopes committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    497a69d View commit details
    Browse the repository at this point in the history

  39. langauge server channel macro docs

    @micahscopes
    micahscopes committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    92a45cd View commit details
    Browse the repository at this point in the history

  40. cleanup stream/backend organization

    @micahscopes
    micahscopes committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    a40b5e0 View commit details
    Browse the repository at this point in the history

  41. more language server reorganization

    @micahscopes
    micahscopes committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    9e296ce View commit details
    Browse the repository at this point in the history

  42. remove unused dependencies from language server

    @micahscopes
    micahscopes committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    3fd2fea View commit details
    Browse the repository at this point in the history

  43. improved go-to and hover functionality

    @micahscopes
    micahscopes committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    5f00e76 View commit details
    Browse the repository at this point in the history

  44. vscode extension comment toggling, autoclose

    @micahscopes
    micahscopes committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    988bda0 View commit details
    Browse the repository at this point in the history

  45. fix hanging diagnostic workers

    @micahscopes
    micahscopes committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    04b3fc2 View commit details
    Browse the repository at this point in the history

  46. no need for workspace lock

    @micahscopes
    micahscopes committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    1c02042 View commit details
    Browse the repository at this point in the history

  47. cleanup hover/diagnostic handlers

    @micahscopes
    micahscopes committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    4bd60a4 View commit details
    Browse the repository at this point in the history

Commits on Mar 29, 2024

  1. cleanup language server database

    @micahscopes
    micahscopes committed Mar 29, 2024
    Configuration menu
    Copy the full SHA
    6ae80ca View commit details
    Browse the repository at this point in the history

Commits on Apr 1, 2024

  1. Applied some suggestions from review

    @micahscopes
    micahscopes committed Apr 1, 2024
    Configuration menu
    Copy the full SHA
    cdd3a1b View commit details
    Browse the repository at this point in the history

  2. Apply suggestions from code review 

    Co-authored-by: Yoshitomo Nakanishi <yurayura.rounin.3@gmail.com>
Co-authored-by: Sean Billig <sean.billig@gmail.com>
    @micahscopes @Y-Nak @sbillig
    3 people authored Apr 1, 2024
    Configuration menu
    Copy the full SHA
    824966e View commit details
    Browse the repository at this point in the history

  3. Integrate review suggestions

    @micahscopes
    micahscopes committed Apr 1, 2024
    Configuration menu
    Copy the full SHA
    c697a17 View commit details
    Browse the repository at this point in the history

  4. Implement @Y-Nak's suggested goto improvements

    @micahscopes
    micahscopes committed Apr 1, 2024
    Configuration menu
    Copy the full SHA
    d8ecf22 View commit details
    Browse the repository at this point in the history