Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Language server concurrency and functionality upgrades #979

Open
wants to merge 66 commits into
base: fe-v2
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
66 commits
Select commit Hold shift + click to select a range
e5c5d09
Start moving LSP server to tower
micahscopes Jan 11, 2024
1e30c00
tower-lsp logging
micahscopes Jan 12, 2024
9589ef1
language server clippy/fmt
micahscopes Jan 12, 2024
936986f
language server tower refactor minor cleanup
micahscopes Jan 15, 2024
dbda904
language server tower-lsp refactor cleanup; WIP
micahscopes Jan 18, 2024
f28784e
language server clippy/fmt
micahscopes Jan 19, 2024
54a1c59
Language server prevent deadlocks
micahscopes Jan 22, 2024
41e206a
language server: clarify async shared state design
micahscopes Jan 26, 2024
f3dc655
language server code cleanup
micahscopes Jan 26, 2024
fcdd0d9
workspace file removal improvement
micahscopes Jan 29, 2024
7a67675
generate LSP event channels automatically
micahscopes Feb 29, 2024
f56052a
attempt at oneshot responses
micahscopes Mar 1, 2024
843ed9a
stream handlers for LSP functionality
micahscopes Mar 1, 2024
63fd1cd
formatting and cleanup
micahscopes Mar 1, 2024
763a956
language server concurrency progress
micahscopes Mar 1, 2024
07eaa42
no deadlocks
micahscopes Mar 1, 2024
71d48a7
no need for state locks!
micahscopes Mar 1, 2024
a9e69a7
goto, hover; prevent panic in LSP channel response
micahscopes Mar 5, 2024
bbef3a3
formatting
micahscopes Mar 5, 2024
c9f9984
clippy
micahscopes Mar 5, 2024
a3079db
pull some LSP channel code out of proc macro for better debugging
micahscopes Mar 5, 2024
e1e9efb
avoid unnecessary manual spawns
micahscopes Mar 5, 2024
45ef9f3
separate tokio runtime for stream handling
micahscopes Mar 6, 2024
c37db92
generated struct name customization
micahscopes Mar 6, 2024
ff33a22
lsp channel responder cleanup
micahscopes Mar 6, 2024
d9c35b6
cleanup; remove unneeded lock
micahscopes Mar 6, 2024
8e7d64c
exclude language-server from wasm tests
micahscopes Mar 6, 2024
29b2197
formatting
micahscopes Mar 6, 2024
4b109a5
separate workspace file methods by mutability
micahscopes Mar 8, 2024
e2dd385
language server get rid of unnecessary mutable references
micahscopes Mar 8, 2024
6356ba4
language server: even Arc/RwLock wrapped salsadb is not Send/Sync
micahscopes Mar 8, 2024
dad57c1
language server: reflock issues are due to salsa!
micahscopes Mar 8, 2024
693f67b
Revert "language server: reflock issues are due to salsa!"
micahscopes Mar 10, 2024
6a2cc6f
Revert "language server: even Arc/RwLock wrapped salsadb is not Send/…
micahscopes Mar 10, 2024
64e24f1
language server snapshot mechanism
micahscopes Mar 10, 2024
9c46292
multithreaded diagnostics
micahscopes Mar 11, 2024
93a2c1b
language server: use mpsc instead of broadcast channels
micahscopes Mar 11, 2024
d530bdd
language server: proc macro cleanup
micahscopes Mar 11, 2024
bdbf124
language server buffer/release mechanism
micahscopes Mar 11, 2024
e5c1a4b
buffer/release stream
micahscopes Mar 11, 2024
cb492ff
higher order stream buffer
micahscopes Mar 12, 2024
7ae47ad
language server tweaks
micahscopes Mar 12, 2024
dd983aa
use unbounded channels
micahscopes Mar 12, 2024
55dbc4d
language server tower-lsp rewrite cleanup
micahscopes Mar 14, 2024
e746872
workspace cleanup; fix panic
micahscopes Mar 19, 2024
b464e12
formatting
micahscopes Mar 19, 2024
ea9351f
remove unused stream modifier; rustfmt
micahscopes Mar 19, 2024
a844f57
language server: load fe std lib in language server
micahscopes Mar 19, 2024
ac213e6
batched ingot-wide diagnostics; cleanup
micahscopes Mar 19, 2024
e56f9a4
test files for language server hover docs
micahscopes Mar 19, 2024
fcd2264
language server: use `tracing` and `tracing-subscriber`
micahscopes Mar 27, 2024
497a69d
temporarily suppress dead code warning
micahscopes Mar 27, 2024
92a45cd
langauge server channel macro docs
micahscopes Mar 28, 2024
a40b5e0
cleanup stream/backend organization
micahscopes Mar 28, 2024
9e296ce
more language server reorganization
micahscopes Mar 28, 2024
3fd2fea
remove unused dependencies from language server
micahscopes Mar 28, 2024
5f00e76
improved go-to and hover functionality
micahscopes Mar 28, 2024
988bda0
vscode extension comment toggling, autoclose
micahscopes Mar 28, 2024
04b3fc2
fix hanging diagnostic workers
micahscopes Mar 28, 2024
1c02042
no need for workspace lock
micahscopes Mar 28, 2024
4bd60a4
cleanup hover/diagnostic handlers
micahscopes Mar 28, 2024
6ae80ca
cleanup language server database
micahscopes Mar 28, 2024
cdd3a1b
Applied some suggestions from review
micahscopes Apr 1, 2024
824966e
Apply suggestions from code review
micahscopes Apr 1, 2024
c697a17
Integrate review suggestions
micahscopes Apr 1, 2024
d8ecf22
Implement @y-nak's suggested goto improvements
micahscopes Apr 1, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ jobs:
# wasm-pack needs a Cargo.toml with a 'package' field.
# (see https://github.com/rustwasm/wasm-pack/issues/642)
# This will still run all tests in the workspace.
run: wasm-pack test --node crates/fe --workspace
run: wasm-pack test --node crates/fe --workspace --exclude fe-language-server

release:
# Only run this when we push a tag
Expand Down
7 changes: 5 additions & 2 deletions .vscode/launch.json
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,8 @@
{
"args": [
"--extensionDevelopmentPath=${workspaceFolder}/crates/language-server/editors/vscode",
"${workspaceFolder}/crates/"
"${workspaceFolder}/crates/",
"--disable-extensions"
],
"name": "Launch Fe VSCode Extension",
"outFiles": [
Expand All @@ -18,8 +19,10 @@
"type": "extensionHost",
// we need to enable backtrace on the extension host
"env": {
"RUST_BACKTRACE": "1"
"RUST_BACKTRACE": "full"
}
// we need to disable rust-analyzer it's so slow

},
]
}
Loading
Loading