Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

travis, Dockerfile, appveyor, build: bump to Go 1.11 #17519

Closed
wants to merge 1 commit into from

Conversation

SamuelMarks
Copy link
Contributor

@SamuelMarks SamuelMarks commented Aug 27, 2018

@karalabe
Copy link
Member

Please bump the docker images too, the general travis build steps too, and add 1.10 as a legacy step.

@SamuelMarks
Copy link
Contributor Author

Looks like the new Docker images aren't available yet: https://hub.docker.com/_/golang/

@nonsense
Copy link
Member

@SamuelMarks I believe we have to update more files than that. See previous PRs that added Go 1.10 as an example: #16128

@SamuelMarks SamuelMarks changed the title travis, appveyor: update to Go 1.11 travis, Dockerfile, appveyor, build: bump to Go 1.11 Aug 27, 2018
@karalabe
Copy link
Member

You are still missing the 1.10.x Travis build steps.

@SamuelMarks
Copy link
Contributor Author

😅 need to improve my sed foo!

@karalabe
Copy link
Member

Thanks for this! I've opened a superseding PR (with your commit cherry picked) as we need a few more code changes to make everything compatible with Go 1.11. I also needed to make a tiny fix to your PR: the ubuntu xenial packages cannot be upgraded to Go 1.11 because it has been end-of-life-d before 1.11 appeared, so there are no 1.11 packages.

That said, there's no point to update those because we're dropping support for all the images in the containers folder in favor of the main alpine images.

Updated PR at: #17701

@karalabe karalabe closed this Sep 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants