Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

travis, Dockerfile, appveyor, build: bump to Go 1.11 #17701

Merged
merged 2 commits into from
Sep 19, 2018

Conversation

karalabe
Copy link
Member

No description provided.

@karalabe
Copy link
Member Author

Copy link
Contributor

@holiman holiman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blindly trusting you!

@karalabe
Copy link
Member Author

Famous last words

@karalabe karalabe merged commit 736b45a into ethereum:master Sep 19, 2018
@SamuelMarks
Copy link
Contributor

@karalabe Oh, it was literally the lack of linted code that stopped it compiling? - Great, happy this is merging then 👍

@karalabe
Copy link
Member Author

It wasn't stopping it from compiling, rather we have a linter CI step to prevent pushing badly formatted code into the repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants