Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

all: move main transaction pool into a subpool #27463

Merged
merged 4 commits into from
Jun 16, 2023

Conversation

karalabe
Copy link
Member

This PR is a refactor to move the txpool.TxPool implementation to legacypool.LegacyPool, which will be a sibling to the upcoming blobpool.BlobPool. The integration of the 2 pools will be lightyears simpler if the two are siblings and not parent-child relationship. This abstraction also allows us to move the local txs into their own pool and further simplify the main txpool (legacypool from now on).

The reason I named it legacypool instead of something more permanent is because I think we should rethink and reimplement the txpool to use some persistency soon rather than later, so might as well start that idea now.

@karalabe karalabe added this to the 1.12.1 milestone Jun 13, 2023
@karalabe karalabe mentioned this pull request Jun 6, 2023
26 tasks
core/txpool/subpool.go Outdated Show resolved Hide resolved
core/txpool/subpool.go Show resolved Hide resolved
core/txpool/txpool.go Show resolved Hide resolved
core/txpool/txpool.go Show resolved Hide resolved
core/types/transaction_test.go Show resolved Hide resolved
core/txpool/subpool.go Outdated Show resolved Hide resolved
Copy link
Contributor

@holiman holiman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All in all, looks good to me

go.mod Outdated Show resolved Hide resolved
core/txpool/txpool.go Outdated Show resolved Hide resolved
@karalabe karalabe merged commit d40a255 into ethereum:master Jun 16, 2023
devopsbo3 pushed a commit to HorizenOfficial/go-ethereum that referenced this pull request Nov 10, 2023
* all: move main transaction pool into a subpool

* go.mod: remove superfluous updates

* core/txpool: review fixes, handle txs rejected by all subpools

* core/txpool: typos
devopsbo3 added a commit to HorizenOfficial/go-ethereum that referenced this pull request Nov 10, 2023
devopsbo3 added a commit to HorizenOfficial/go-ethereum that referenced this pull request Nov 10, 2023
@samlaf
Copy link
Contributor

samlaf commented Sep 2, 2024

I think we should rethink and reimplement the txpool to use some persistency soon rather than later

@karalabe has work on this started yet? And is there a design doc or issue explaining what you meant by this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants