Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core/txpool: remove redundant check for floatingRatio == 0 #27477

Merged
merged 1 commit into from
Jun 19, 2023
Merged

core/txpool: remove redundant check for floatingRatio == 0 #27477

merged 1 commit into from
Jun 19, 2023

Conversation

hero5512
Copy link
Contributor

No description provided.

@fjl
Copy link
Contributor

fjl commented Jun 15, 2023

Care to explain?

@hero5512
Copy link
Contributor Author

Care to explain?
floatingRatio is a constant value and always is non-zero. so there is no need to check this value

@fjl
Copy link
Contributor

fjl commented Jun 15, 2023

Thanks! Please, if possible, explain your PRs in the description. It is expected and makes the review easier for us.

@fjl fjl changed the title core/txpool: rm redundant check floatingRatio == 0 core/txpool: remove edundant check for floatingRatio == 0 Jun 15, 2023
@fjl fjl changed the title core/txpool: remove edundant check for floatingRatio == 0 core/txpool: remove redundant check for floatingRatio == 0 Jun 15, 2023
@hero5512
Copy link
Contributor Author

Thanks! Please, if possible, explain your PRs in the description. It is expected and makes the review easier for us.

ok

@karalabe
Copy link
Member

Please don't merge until #27463 is in

@karalabe
Copy link
Member

Pls rebase, the txpool package was moved to core/txpool/legacypool.

@hero5512
Copy link
Contributor Author

Pls rebase, the txpool package was moved to core/txpool/legacypool.

done

@fjl fjl merged commit a71b9b9 into ethereum:master Jun 19, 2023
@fjl fjl added this to the 1.12.1 milestone Jun 19, 2023
devopsbo3 pushed a commit to HorizenOfficial/go-ethereum that referenced this pull request Nov 10, 2023
@hero5512 @devopsbo3
core/txpool/legacypool: remove redundant check for floatingRatio == 0 (…
d97bfa6 
…ethereum#27477)

floatingRatio is a constant and always non-zero. So there is no need to
check for == 0.
devopsbo3 added a commit to HorizenOfficial/go-ethereum that referenced this pull request Nov 10, 2023
@devopsbo3
Revert "core/txpool/legacypool: remove redundant check for floatingRa…
3797890 
…tio == 0 (ethereum#27477)"

This reverts commit d97bfa6.
devopsbo3 added a commit to HorizenOfficial/go-ethereum that referenced this pull request Nov 10, 2023
@devopsbo3
Revert "core/txpool/legacypool: remove redundant check for floatingRa…
f6aab03 
…tio == 0 (ethereum#27477)"

This reverts commit d97bfa6.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rjl493456442 rjl493456442 rjl493456442 approved these changes

@fjl fjl fjl approved these changes

@karalabe karalabe Awaiting requested review from karalabe karalabe is a code owner

@holiman holiman Awaiting requested review from holiman holiman is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.12.1
Development

Successfully merging this pull request may close these issues.
4 participants
@hero5512 @fjl @karalabe @rjl493456442