This repository has been archived by the owner on Sep 5, 2020. It is now read-only.
refactor OS-specific menu-items #1192
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -71,7 +71,8 @@ | |||
| "toFront": "Bring All to Front" | |||
| }, | |||
| "help": { | |||
| "label": "Help" | |||
| "label": "Help", | |||
| "reportBug": "Report a bug on Github" | |||
There was a problem hiding this comment.
i created that reportbug thing. Maybe we should rephrase to "Report an issue on Github"?
evertonfraga
reviewed
Oct 7, 2016
| } | ||
| ); | ||
| } | ||
| if(process.platform === 'darwin') { |
There was a problem hiding this comment.
@luclu is there a reason why is this enabled only on Mac?
There was a problem hiding this comment.
anyways, I removed this restriction and tested on Linux+Win. all worked
evertonfraga
approved these changes
Oct 7, 2016
| } | ||
| ); | ||
| } | ||
| if(process.platform === 'darwin') { |
There was a problem hiding this comment.
anyways, I removed this restriction and tested on Linux+Win. all worked
|
merged on #1269. |
|
This thread has been automatically locked because it has not had recent activity. Please open a new issue for related bugs and link to relevant comments in this thread. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1168
Tested on win, linux, mac