This repository has been archived by the owner on Sep 5, 2020. It is now read-only.
Adding rinkeby support #2723
Merged
Adding rinkeby support #2723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into add-rinkeby-support
…into add-rinkeby-support
frozeman
reviewed
Jul 9, 2017
| @@ -46,7 +46,7 @@ | |||
| </p> | |||
|
|
|||
| {{#if TemplateVar.get "testnet"}} | |||
| <p>{{{i18n "mist.popupWindows.onboarding.mineItDescription"}}}</p> | |||
| <p>{{{i18n "mist.popupWindows.onboarding.FaucetDescription"}}}</p> | |||
There was a problem hiding this comment.
I would have made that camelCase
frozeman
reviewed
Jul 9, 2017
| @@ -81,7 +90,7 @@ Template['popupWindows_onboardingScreen'].helpers({ | |||
|
|
|||
| @method syncStatus | |||
| */ | |||
| 'syncStatus': function () { | |||
| syncStatus() { | |||
There was a problem hiding this comment.
Thats ES6 right here, if we would remove the ecmascript package, this would break.
frozeman
approved these changes
Jul 9, 2017
frozeman
reviewed
Jul 9, 2017
| else { | ||
| switch (network) { | ||
| // STARTS ROPSTEN | ||
| case 'test': |
There was a problem hiding this comment.
why we call this "test" and the other by its name? To be backwards compatible?
There was a problem hiding this comment.
There are some reasons:
- backwards compatibility, yes
- Geth refers to the networks as
--testnetand--rinkeby, so we're actually being consistent with their flags - forward compatibility: that'll work even if the testnet flag changes to a different chain, so we're not being specific to Ropsten in the internals, only when it's displayed.
|
I didn't test it on my machine, but it looks good from the code changes. |
|
This thread has been automatically locked because it has not had recent activity. Please open a new issue for related bugs and link to relevant comments in this thread. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a bonus, user can also choose a local private network.